-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport improvements from 2024-W49 #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
- Coverage 77.6% 76.7% -1.0%
=======================================
Files 211 211
Lines 16108 16108
=======================================
- Hits 12511 12363 -148
- Misses 3597 3745 +148
|
e0e1fb6
to
8967c53
Compare
3c9192d
to
b1f411e
Compare
2a9f63c
to
202c41c
Compare
d384ef5
to
a6022ee
Compare
- Only write the file if it is different from a refreshed codelist. - Use ScenarioCodeAnnotations class. - Add Config.use_scenario_code() - Update base scenario URLs.
Replace with annotations in CL_TRANSPORT_SCENARIO.
This commodity is not used in IEA EWEB 2024 data for 2019, so we constrain its activity to a low, non-zero level.
Mirror calculation flow in .ldv for same parameter.
"output" for most technologies is dimensionless because ACT and the output commodities have the same units.
- R12_MEA reduction purely based on very high 2025 demand numbers that are unrealistic.
- R12_WEU to match 2019-based estimates. - R12_MEA purely based on very high 2025 demand numbers that are unrealistic. Aviation adjustment based on scale-1.
- R12_MEA based on scale-1 and high 2025 values. - R12_SAS based on scale 1 and 2025 values (AIR is too high and demand is too high as well).
Remove values for: - R12_AFR, ROAD, ethanol - R12_FSU, ROAD, electr - R12_LAM, ROAD, gas - R12_MEA, RAIL, lightoil - R12_PAO, ROAD, gas - R12_RCPA, RAIL, lightoil - R12_RCPA, ROAD, gas - Add values for: - R12_AFR, RAIL, lightoil - R12_CHN, ROAD, electr - R12_NAM, RAIL, lightoil - R12_PAO, ROAD, ethanol - R12_RCPA, ROAD, ethanol - R12_SAS, ROAD, ethanol - Adjust all others
- Store context.core.local_data on pytestconfig for reference. - Add user_local_data fixture for development.
- Sort variables and functions. - Split main() to prepare_method_A(). - Add main(…, method=…) argument. - Add stub prepare_method_B().
- Separate STRUCTURE_STATIC and use Computer.add_queue() for clarity. - Add docstrings listing all added keys/tasks. - Move function to .operator.write_report_debug().
a6022ee
to
2acaf26
Compare
Will merge without code owner review from @r-aneeque, as he's on annual leave. |
3 tasks
khaeru
added a commit
that referenced
this pull request
Jan 29, 2025
- Set units for 'output' param in .ldv.prepare_tech_econ(). - .transport.files.population_suburb_share is required.
khaeru
added a commit
that referenced
this pull request
Jan 29, 2025
- Set units for 'output' param in .ldv.prepare_tech_econ(). - .transport.files.population_suburb_share is required.
khaeru
added a commit
that referenced
this pull request
Jan 29, 2025
- Set units for 'output' param in .ldv.prepare_tech_econ().
khaeru
added a commit
that referenced
this pull request
Jan 29, 2025
- Set units for 'output' param in .ldv.prepare_tech_econ().
khaeru
added a commit
that referenced
this pull request
Jan 29, 2025
- Set units for 'output' param in .ldv.prepare_tech_econ().
9 tasks
khaeru
added a commit
that referenced
this pull request
Jan 31, 2025
- Set units for 'output' param in .ldv.prepare_tech_econ().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
p:SSP-2024
2024 SSP updates and ScenarioMIP
transport
MESSAGEix-Transport variant or transport in the base model
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ixmp://ixmp-dev/SSP_dev_SSP1_v0.1_Blv0.18/baseline_prep_lu_bkp_solved_materials
to e.g.ixmp://ixmp-dev/SSP_SSP1_v1.1/baseline_DEFAULT_step_13
.[ ]Next PR: Use a smallergrowth_activity_up
value for (t=ICAm_ptrp, n=R12_RCPA). The technology constraint as of 2020 is effective, but this tech/region grows too rapidly to 2025 and beyond. (per discussion with @r-aneeque 2024-12-04.)[ ]Next PR: Adjust efficiencies of LDV PHEV technologies using duty cycle data.[ ]Next PR: Ensuregrowth_activity_up
andact-non_ldv.csv
values are set forF ROAD
technologies with, at least, c=gas inputs. This is to avoid the behaviour (observed by @r-aneeque) that the model quickly switches into these in 2025–2030. Rework.transport.Config.constraint
to simplify the setting of these constraints.This branch
is currentlywas temporarily triggering the message_data transport runs using iiasa/message_data#582, which limits to a subset of all scenarios.How to review
Per aviation emissions:
message_ix_models/data/transport/emi-intensity.csv
.More TBA
PR checklist