-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport improvements from 2025-W05 #289
Draft
khaeru
wants to merge
27
commits into
main
Choose a base branch
from
transport/2025-w05
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,049
−374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3da90c3
to
bd02b58
Compare
04701ce
to
a0b8292
Compare
- Add MockScenario() class.
- Load parameter data directly from an export of a built scenario. - Parametrize test_simulated_solution()
- get_cl() - get_cs() - get_concept() - get_version()
Available from Python 3.9 onwards.
- Sort globals, then methods in alpha order. - Add .key.report.all = "transport all", use in other modules.
- Use .freight.Fi consistently - Edit .non_ldv docstring
- Add message_ix_models.report.key for general keys with GDP, PRICE_COMMODITY. - Use a KeySeq for .transport.key.price.
Avoid logged errors in _convert_units().
a0b8292
to
9ddfad7
Compare
- Shift utility function to .util.has_input_commodity(). - Correct filter for gas-using techs to constrain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carried from #259:
growth_activity_up
value for (t=ICAm_ptrp, n=R12_RCPA). The technology constraint as of 2020 is effective, but this tech/region grows too rapidly to 2025 and beyond. (per discussion with @r-aneeque 2024-12-04.)growth_activity_up
andact-non_ldv.csv
values are set forF ROAD
technologies with, at least, c=gas inputs. This is to avoid the behaviour (observed by @r-aneeque) that the model quickly switches into these in 2025–2030. Rework.transport.Config.constraint
to simplify the setting of these constraints.In addition:
How to review
TBA
PR checklist