Handle empty news result from Scrape It api (#138)

Signed-off-by: Sean Sundberg <[email protected]>
ibm-ecosystem-engineering · Nov 6, 2023 · 3dda41f · 3dda41f
1 parent 9c3cd78
commit 3dda41f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/services/negative-news/negative-news.impl.ts b/src/services/negative-news/negative-news.impl.ts
@@ -539,10 +539,12 @@ export class NegativeNewsImpl implements NegativeNewsApi {
             "tbm": "nws",
         }
 
-        return queue.add(() => this.service.scrape(params)).catch(err => {
-            console.log('Error accessing Scrapeit: ', {err})
-            throw err
-        }) as Promise<SearchResult[]>
+        return queue
+            .add(() => this.service.scrape(params))
+            .catch(err => {
+                console.log('Error accessing Scrapeit: ', {err})
+                throw err
+            }) as Promise<SearchResult[]>
     }
 
     async validateUrls(data: SearchResult[]): Promise<{validUrls: ValidatedSearchResult[], badUrls: ValidatedSearchResult[]}> {

diff --git a/src/services/web-scrape/web-scrape.scrapeit.ts b/src/services/web-scrape/web-scrape.scrapeit.ts
@@ -11,6 +11,6 @@ export class WebScrapeScrapeit implements WebScrapeApi {
 
     scrape(params: WebScrapeParams): Promise<SearchResult[]> {
         return this.service.scrape(params)
-            .then(response => response.newsResults);
+            .then(response => response.newsResults || []);
     }
 }