Add test for undefined array value in negative news flow (#137)

Signed-off-by: Sean Sundberg <[email protected]>
ibm-ecosystem-engineering · Nov 6, 2023 · 9c3cd78 · 9c3cd78
1 parent b8490dc
commit 9c3cd78
Showing 1 changed file with 30 additions and 0 deletions.
diff --git a/src/services/negative-news/negative-news.impl.ts b/src/services/negative-news/negative-news.impl.ts
@@ -546,6 +546,12 @@ export class NegativeNewsImpl implements NegativeNewsApi {
     }
 
     async validateUrls(data: SearchResult[]): Promise<{validUrls: ValidatedSearchResult[], badUrls: ValidatedSearchResult[]}> {
+        if (!data) {
+            const message: string = 'validateUrls() data value is undefined'
+            console.log(message)
+            throw new Error(message)
+        }
+
         const validatedData: ValidatedSearchResult[] = await Promise.all(
             data.map(this.validateUrl.bind(this))
         )
@@ -568,6 +574,12 @@ export class NegativeNewsImpl implements NegativeNewsApi {
 
     async checkAllNegativeNews(news: ValidatedSearchResult[], generate: GenerateFunction): Promise<{negativeNews: ScoredSearchResult[], positiveNews: ScoredSearchResult[]}> {
 
+        if (!news) {
+            const message: string = 'checkAllNegativeNews() news value is undefined'
+            console.log(message)
+            throw new Error(message)
+        }
+
         const results: ScoredSearchResult[] = await Promise.all(news.map(val => this.checkNegativeNews(val, generate)))
 
         return {
@@ -609,6 +621,12 @@ export class NegativeNewsImpl implements NegativeNewsApi {
 
     async summarizeAllNews(news: ScoredSearchResult[], generate: GenerateFunction): Promise<SummarizedSearchResult[]> {
 
+        if (!news) {
+            const message: string = 'summarizeAllNews() news value is undefined'
+            console.log(message)
+            throw new Error(message)
+        }
+
         return Promise.all(news.map(news => this.summarizeNews(news, generate)))
     }
 
@@ -624,6 +642,12 @@ export class NegativeNewsImpl implements NegativeNewsApi {
 
     async filterAllNews(negativeNews: SummarizedSearchResult[], subjectName: string, generate: GenerateFunction, filterParams?: {countryOfResidence?: string, dateOfBirth?: string}): Promise<{tp: FilteredSearchResult[], fp: FilteredSearchResult[]}> {
 
+        if (!negativeNews) {
+            const message: string = 'filterAllNews() negativeNews value is undefined'
+            console.log(message)
+            throw new Error(message)
+        }
+
         const result = await Promise.all(
             negativeNews.map(news => this.filterNews(news, subjectName, generate, filterParams))
         )
@@ -727,6 +751,12 @@ export class NegativeNewsImpl implements NegativeNewsApi {
     }
 
     extractTopics(vals: FilteredSearchResult[]) {
+        if (!vals) {
+            const message: string = 'extractTopics() vals parameter is undefined'
+            console.log(message)
+            throw new Error(message)
+        }
+
         return vals
             .map(val => val.negativeNewsTopics)
             .reduce((topics: string[], current: string[]) => {