Add and use the cpu_features library for feature detect #16862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this "cross-platform C library" leaves some cross-platformness to be desired, so it's only used where supported. Still, it seems more well tested and has some fixes for misreported flags on ARM processors, etc.
I had to throw out its CMakeLists.txt, because it doesn't build at all on macOS and had relative path errors when used as an
add_subdirectory()
.It seems like it might at some point soon (?) support macOS/iOS and Windows for ARM64. It also does some logic to pull getauxval() dynamically because Android is annoying.
It would be worth trying this against some old Android like Xperia Play before merging.
Also threw in RISC-V half-float encodings, since they're ratified and just minor variation on existing instructions (not sure if we'd use them, maybe the convert between 16/32...)
-[Unknown]