Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ARM64 Crypto Extensions ( Need to test ) #16846

Closed
wants to merge 1 commit into from

Conversation

zminhquanz
Copy link
Contributor

@zminhquanz zminhquanz commented Jan 25, 2023

-About Vero4k line , because they have the check Aarch64 on below if report failed , not detect it , so i remove it because it's unnecessary
-I need someone to test on real device , using Device Info HW app to compare it
-Already test on my Galaxy S10 Qualcomm version and it's correct

-About Vero4k line , because they have the check AARCH64 on below if report failed , not detect it , so i remove it because it's unnecessary
-I need someone to test on real device , using Device Info HW app to compare it
@ghost
Copy link

ghost commented Jan 25, 2023

Can you also do this #10620 (comment)?

@zminhquanz
Copy link
Contributor Author

zminhquanz commented Jan 25, 2023

Can you also do this #10620 (comment)?

Later , because i need to find another solution , so this commit just add logic of extension check in CPU Extensions tab

@unknownbrackets
Copy link
Collaborator

Indentation is wrong.

I suppose some of these might be useful, like ASIMDRDM, ASIMDFHM, ASIMDDP, FRINT, SVE2, RPRES, I8MM, and CRC32. But most of these I just can't see us even using. Is there a reason to detect all of them?

-[Unknown]

@zminhquanz
Copy link
Contributor Author

Indentation is wrong.

I suppose some of these might be useful, like ASIMDRDM, ASIMDFHM, ASIMDDP, FRINT, SVE2, RPRES, I8MM, and CRC32. But most of these I just can't see us even using. Is there a reason to detect all of them?

-[Unknown]

ASIMDRDM is Advanced SIMD Rounding Double Multiply , from ARMv8.1 like Cortex A72 will have it
ASIMDDP is Advanced SIMD Dot Product , from ARMv8.2 will have it
CRC32 some of ARMv8.0 soc have it ,i have Nexus 9 using NVIDIA Tegra K1
but SVE or SVE2 most of mobile SOC don't have it , so it won't show
ASIMDFHM , FRINT , I8MM on my Xiaomi 13 using Snapdragon 8 gen 2 have it

@unknownbrackets
Copy link
Collaborator

Well, I just mean that - without actually adding something to the emitter or etc., these won't be used anyway. If they aren't useful enough for us to ever do that, such as SSBS, it doesn't seem very worth detecting or showing them. Even the dot product one is questionably useful, because it only operates on 8-bit values iirc. Maybe could use it in softgpu somewhere...

SVE/SVE2 could be more useful, wish more devices supported them...

-[Unknown]

@hrydgard
Copy link
Owner

With #16871, is this still relevant?

@unknownbrackets
Copy link
Collaborator

I added the few I could really see us using in #16862, so possibly not.

-[Unknown]

@hrydgard hrydgard closed this Feb 1, 2023
@ghost
Copy link

ghost commented Feb 1, 2023

Question might be unrelated to this pr but on my MT6592 android phone it detect many cpu extension.
received_867607317875221
But on my vivo y11 snapdragon 439 detect only two cpu extension.
Screenshot_20230201_180440_2f85358b2198d26f8aca533d68bee793

@hrydgard
Copy link
Owner

hrydgard commented Feb 1, 2023

Your first phone there is ARM32, which needs a lot of extensions for fairly basic functionality, which is all included by default in ARM64 (which is your second phone). So it's not like the first one has any capability that the second one doesn't.

@ghost
Copy link

ghost commented Feb 1, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants