-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ARM64 Crypto Extensions ( Need to test ) #16846
Conversation
-About Vero4k line , because they have the check AARCH64 on below if report failed , not detect it , so i remove it because it's unnecessary -I need someone to test on real device , using Device Info HW app to compare it
Can you also do this #10620 (comment)? |
Later , because i need to find another solution , so this commit just add logic of extension check in CPU Extensions tab |
Indentation is wrong. I suppose some of these might be useful, like ASIMDRDM, ASIMDFHM, ASIMDDP, FRINT, SVE2, RPRES, I8MM, and CRC32. But most of these I just can't see us even using. Is there a reason to detect all of them? -[Unknown] |
ASIMDRDM is Advanced SIMD Rounding Double Multiply , from ARMv8.1 like Cortex A72 will have it |
Well, I just mean that - without actually adding something to the emitter or etc., these won't be used anyway. If they aren't useful enough for us to ever do that, such as SSBS, it doesn't seem very worth detecting or showing them. Even the dot product one is questionably useful, because it only operates on 8-bit values iirc. Maybe could use it in softgpu somewhere... SVE/SVE2 could be more useful, wish more devices supported them... -[Unknown] |
With #16871, is this still relevant? |
I added the few I could really see us using in #16862, so possibly not. -[Unknown] |
Your first phone there is ARM32, which needs a lot of extensions for fairly basic functionality, which is all included by default in ARM64 (which is your second phone). So it's not like the first one has any capability that the second one doesn't. |
Ok thanks for good explanation Sir @HenrikRydgard
…On Wednesday, February 1, 2023, Henrik Rydgård ***@***.***> wrote:
Your first phone there is ARM32, which needs a lot of extensions for
fairly basic functionality, which is included in ARM64 (which is your
second phone) by default. So it's not like the first one has any capability
that the second one doesn't.
—
Reply to this email directly, view it on GitHub
<#16846 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI64R2RN7SSEARRRIO3EMCDWVIY3LANCNFSM6AAAAAAUGFRVYQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
-About Vero4k line , because they have the check Aarch64 on below if report failed , not detect it , so i remove it because it's unnecessary
-I need someone to test on real device , using Device Info HW app to compare it
-Already test on my Galaxy S10 Qualcomm version and it's correct