-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Add spreadsheet component #355
Conversation
@michaelbukachi tested and the drag/drop feature is awesome! Looking forward to testing the other features 🚀 |
@michaelbukachi Tested:
|
@andrewtpham The funny thing is this is also the default behaviour on the H-Table/El-table 🤔 . |
@michaelbukachi oh ok, thanks for pointing that out. Then I'll create a separate issue for this to solve under Besides updating the |
for adding new rows we can follow the current setup of Projects list.
|
Hey @michaelbukachi do you think you'll have time this week to wrap up the PR? Then we can start on the FE |
@michaelbukachi the new spreadsheet component is looking good! What's left do to in this first iteration? |
For column filters:
@andrewtpham to share data types to be set for the spreadsheet columns. |
@michaelbukachi The data types we should support in the spreadsheet are:
We can these in the future:
|
for category field:
|
Hey @michaelbukachi, was testing based on your last commit. Should I be able to add the wrong data type in these 3 columns? |
Validations:
|
@michaelbukachi updated the designs to display an entire row when the |
Note:
|
Note:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it looks great! Well done 🙇♂️
@michaelbukachi if you're okay, let's merge this and then we can open a separate PR to add the following:
|
@andrewtpham Sure thing. No problem. |
What is the Purpose?
This PR adds a new spreadsheet component
h-table
)Spreadsheet
+H Table
components: Ability to filter a column by its dropdown values (if it is a dropdown field) (built in element) #241What was the approach?
Briefly describe the approach used to address the issue
Are there any concerns to addressed further before or after merging this PR?
State some additional info if any. For instance running
install
or setting some environment variable(s)Mentions?
Mention persons you'd like to review this PR
Issue(s) affected?
Fix #365