Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component for metrics table #286

Closed
4 of 14 tasks
ninetteadhikari opened this issue Apr 21, 2022 · 7 comments · Fixed by #355
Closed
4 of 14 tasks

Add component for metrics table #286

ninetteadhikari opened this issue Apr 21, 2022 · 7 comments · Fixed by #355
Assignees
Labels
UI UI Components
Milestone

Comments

@ninetteadhikari
Copy link
Member

ninetteadhikari commented Apr 21, 2022

Is your feature request related to a problem? Please describe.
spreadsheet-add-row

First iteration

For future enhancements:

  • allow user to control the width of the column
  • allow users to move a row and save the position
  • allow devs to merge cells (header cells): example from ElementUI: https://element.eleme.io/#/en-US/component/table#grouping-table-head
  • allow users to freeze/fix certain columns
  • allows user to use tab key to switch cells
  • make the '+' add button to be sticky at the bottom when the table is long
  • Delete row: need a button to trigger the deletion

Additional context
Link to figma:

@andrewtpham
Copy link
Member

Hey @michaelbukachi there's a related component to this new table that we could add. I also would like to see how it can also be used with the h-table editable component: #241

@andrewtpham
Copy link
Member

Vue spreadsheet component: https://github.com/joffreyBerrier/vue-spreadsheet

@ninetteadhikari
Copy link
Member Author

Update:

@ninetteadhikari
Copy link
Member Author

First iteration: get the basic styling in place
next iterations: column persistence

@ninetteadhikari
Copy link
Member Author

ninetteadhikari commented Aug 1, 2022

Note:

  • For moving columns to a new position we do not need a confirmation.
  • We can leave out the dynamic row height for bigger content size. We can truncate the content so it fits in one row for now. Future enhancement can be done to support dynamic row height.
  • For column header dropdown add a flag to separate between h-table and h-spreadsheet
  • Add tests for the component

@andrewtpham andrewtpham linked a pull request Aug 1, 2022 that will close this issue
10 tasks
@andrewtpham
Copy link
Member

@michaelbukachi I've added a few new screens in the description to help explain the design of the functionality. Let me know if I can clarify anything.

@andrewtpham
Copy link
Member

New spreadsheet design is updated in the description. Figma screens can be found here: https://www.figma.com/file/2bizWQnCDp0r5RZzrM25jX/Dots?node-id=7125%3A60501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI UI Components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants