Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update iso installation page with new cluster cidr and dhcp settings #705

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

ihcsim
Copy link
Contributor

@ihcsim ihcsim commented Jan 13, 2025

This PR updates the ISO installation page to cover new changes added to the cluster CIDRs and DHCP configuration, per the following issues:

harvester/harvester#4254
harvester/harvester#6960

It also updates the Harvester Configuration page to include the new cluster CIDR fields.

Copy link

github-actions bot commented Jan 13, 2025

Name Link
🔨 Latest commit 4339e8e
😎 Deploy Preview https://67897f52aa25da36f638f15d--harvester-preview.netlify.app

Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

docs/install/iso-install.md Show resolved Hide resolved
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

docs/install/harvester-configuration.md Outdated Show resolved Hide resolved
docs/install/harvester-configuration.md Show resolved Hide resolved
docs/install/iso-install.md Outdated Show resolved Hide resolved
@ihcsim
Copy link
Contributor Author

ihcsim commented Jan 16, 2025

@jillian-maroket thanks - fixed in 4339e8e.

@bk201 bk201 merged commit 8a1f2a8 into harvester:main Jan 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants