Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Harvester installer supports to input MAC for VIP in DHCP mode #6960

Open
w13915984028 opened this issue Nov 6, 2024 · 3 comments
Assignees
Labels
area/installer Harvester installer kind/enhancement Issues that improve or augment existing functionality priority/1 Highly recommended to fix in this release require/doc Improvements or additions to documentation
Milestone

Comments

@w13915984028
Copy link
Member

Is your enhancement related to a problem? Please describe.

Harvester supports to configure the VIP MAC in DHCP mode, user can pre define the IP-MAC binding on DHCP server.

However, this is only supported in Automatic mode e.g. iPXE.

In ISO mode, this is not supported.

image

https://docs.harvesterhci.io/v1.4/install/harvester-configuration#installvip

image

Describe the solution you'd like

ISO installation also supports input MAC address for effective IP-MAC binding.

Describe alternatives you've considered

Additional context

Observed on PR harvester/harvester-installer#879

@w13915984028 w13915984028 added kind/enhancement Issues that improve or augment existing functionality area/installer Harvester installer candidate/v1.5.0 labels Nov 6, 2024
@ihcsim
Copy link
Contributor

ihcsim commented Nov 6, 2024

@w13915984028 can i work on this?

@harvesterhci-io-github-bot
Copy link
Collaborator

harvesterhci-io-github-bot commented Dec 11, 2024

Pre Ready-For-Testing Checklist

  • If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
    The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:

This new change allows user to configure the Harvester VIP using DHCP static MAC/IP binding in ISO mode installation. Testing this will require MAC/IP binding to be configured on the DHCP server. An example of how to do this on libvirt can be found here.

See PR for test plan description.

  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:

  • Have the backend code been merged (harvester, harvester-installer, etc) (including backport-needed/*)?
    The PR is at: feat: add VIP mac address input panel harvester-installer#894

    • Does the PR include the explanation for the fix or the feature? yes

    • Does the PR include deployment change (YAML/Chart)? If so, where are the PRs for both YAML file and Chart?
      The PR for the YAML change is at:
      The PR for the chart change is at:

  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

  • If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
    The documentation/KB PR is at: doc: update iso installation page with new cluster cidr and dhcp settings docs#705

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?

    • The automation skeleton PR is at:
    • The automation test case PR is at:
  • If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
    The compatibility issue is filed at:

@harvesterhci-io-github-bot
Copy link
Collaborator

Automation e2e test issue: harvester/tests#1722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installer Harvester installer kind/enhancement Issues that improve or augment existing functionality priority/1 Highly recommended to fix in this release require/doc Improvements or additions to documentation
Projects
Development

No branches or pull requests

6 participants