Update to HAPI FHIR 7.0.0 #618
Conversation
|
Note: WebSockets don't currently work in this PR. Spring-Test 6.x requires Jetty 12, but Spring Boot 3.x seems to be incompatible with Jetty 12, so this is causing some weirdness as we've upgraded hapi-fhir to 12. It looks like this is solved in Spring 6.1 so I'm going to try and get us up to that version soon. |
|
Websockets are now enabled, and this branch has been upgraded to use Jetty 12 |
…t_hapi_7_0 # Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/Application.java
…rting with tomcat, and running as web application doesn't work if the bean is not at least lazy) I'm removing it, it shouldn't be necessary (to run spring-spring boot with jetty, it's enough to enable the jetty profile?)
…nability with jetty and tomcat, tests, and deployment as web application
added required jetty dependencies through spring-boot-starter-jetty so this is the only dependency with scope=testing and transitive dependencies (core jetty libraries) aren't marked as such mvn -P jetty spring-boot:run seems to work
jetty-maven-plugin is obsolete, and jetty-ee10-maven-plugin doesn't work at the moment. Using spring-boot to run local server.
…ing-boot:run by defaults starts tomcat, while the jetty profile enables jetty added a fix to run the generated war with spring-boot on tomcat, due to issues with spring-boot 3.2.0 spring-projects/spring-boot#38585 the jar generated with jetty doesn't work at the moment
…ess "jetty" profile is active (in which case they're done with jetty) Test class JpaStarterWebsocketDispatcherConfig emptied, not sure if necessary (it's now missing jetty dependencies)
|
Hi James, I opened a merge request with your branch as the destination (#624) because I encountered issues when trying it (running spring-boot, tests, packaging a runnable war with at least tomcat, because jetty still has some issues), and had a somewhat hard time solving (or trying to solve) them; I hope you'll find it useful, in whole or part. |
… JpaStarterWebsocketDispatcherConfig and references unrequested changes: commons-logging dependency marked provided (to avoid redundant jar inclusion), removed unused imports in classes that were modified
Revision of jetty dependencies and maven profiles to preserve runnability as webapp, spring-boot, and testing
|
Any idea on when this will be merged? |
|
I'm hitting an issue adding spring security to this branch. https://github.com/hapifhir/hapi-fhir/blob/master/hapi-fhir-storage-cr/pom.xml#L22 I'm seeing app context creation errors when adding my own spring-boot-starter-security dependency to the starter project. I would guess SMILE would have similar issues? My two cents on the side, it might be much easier to maintain things if the HAPI root POM imported the SpringBoot BOM so all dependencies are vetted and compatible with a given SpringBoot version. HAPI is a super-complex project, so possible there are roadblocks to doing that, but.. maybe? EDIT to confirm: I moved my spring-boot-starter-security above hapi-fhir-storage-cr in my POM so it takes precedence and the problems went away. Still - I think hapi-fhir-storage-cr needs to be updated to inherit the spring-security-core version. |
|
@dotasek will this be merged anytime soon? |
dotasek
changed the title
This PR is tracking the HAPI FHIR 7.0.x changes, using Spring 6 / Boot 3, and the new Jakarta APIs