-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate javax.servlet to jakarta.servlet and upgrade to Spring 6 and Boot 3 #2082
Comments
Are there any advantages to making this transition? Healthcare orgs often move very slowly so we'd probably alienate a number of current users of HAPI FHIR if we made a change that prevented deploying on anything but a brand new app container. Unless there is a really compelling reason I can't see us moving anytime soon. |
I'm just trying to work through the migration hell myself... and basically, it appears that nobody supports using old code with new. I'm trying to use Jetty, for example, to deploy my rest code, which uses the new annotations... while also having the Fhir server... and I can't make them play together. Hoping that maybe I can use the tomcat suggested migration tool to change the fhir jars... but haven't tried yet. Have a similar problem with wicket, which also hasn't transitioned. I'd happy to be shown that there was a way to deploy Servlets that use javax on servers that are build for jakarta..... but right now, it appears to be completely incompatible. |
Would it work to just implement both interfaces in the same Servlet class
by any chance?
…On Tue, Sep 15, 2020 at 1:53 PM Dan Armbrust ***@***.***> wrote:
I'm just trying to work through the migration hell myself... and
basically, it appears that nobody supports using old code with new. I'm
trying to use Jetty, for example, to deploy my rest code, which uses the
new annotations... while also having the Fhir server... and I can't make
them play together. Hoping that maybe I can use the tomcat suggested
migration tool to change the fhir jars... but haven't tried yet. Have a
similar problem with wicket, which also hasn't transitioned.
I'd happy to be shown that there was a way to deploy Servlets that use
javax on servers that are build for jakarta..... but right now, it appears
to be completely incompatible.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2N7HPO6L5HHLHHQFPLD3TSF6S2FANCNFSM4RNPHUIA>
.
|
Not sure, I'm still experimenting. I was hoping I would find a little library where someone had just done the translations... but apparently I'm still too early in trying to deal with it. I'll report back if I find anything that makes it relatively easy to be compatible... |
Just stumbled upon this From my (little) experience I don't think it will be possible to support both within the same version. |
I think the likely timeline would be 2023 sometime. This is a really hard thing to time, given the enormous impact it will have on users. There are countless interceptors written against the javax.servlet API, many people who have annoying corporate rules against upgrading to modern containers, etc. I do want to get this done, but it will be tough. |
@jamesagnew ok thanks for the information |
I would also be interested in the migration to Jakarta EE9 because of the Spring Boot 3.x release 😄 |
My team is also interested in this. We need to migrate to springboot 3 because of a CVE, but since hapi fhir still uses javax.servlet we can't :( |
This PR is sort of related to this discussion hapifhir/hapi-fhir-jpaserver-starter#473 |
We are also interested in this because it's blocking us from migrating to Spring Boot 3.x. |
@jamesagnew – is there any update on the prospective timeline for this? |
We are also interested in this because of upgrading spring. |
That's an important question!!! |
This is clearly getting more important to people. I have heard a lot of arguments for it, and none against it. Will try to provide a proposed timeline soon. |
Just wanted to chime in and tell that the Tomcat migration tool mentioned by @darmbrust in the first comment seems to be working, as far as it allowing a minimal Plain Server to be started in Spring Boot 3.0.5 without any errors. The downside is that one has to keep the transformed version of |
Hi. We are also hitting this issue (very "abruptly"). Hapi FHIR plain server/facade. JDK11 is near end of life (normal) support.
SpringBoot.
https://endoflife.date/spring-boot
IMHO:
I have not tried SB 3 with (force override) with Spring Framework 6.x combinations yet. This of course would be a Frankenstein ('s Monster) combination....but will try to find time to try this out. |
@jamesagnew Any updates on a timeline for this? |
Hey, |
looking for timeline for Jakarta Migration? we are using hapi-fhir and its still on javax-based JEE version |
One more consideration, Android 14 SDK (n preview) is supposed to bring partial JDK 17 support sometime after July: |
Hi. Hapi/James has published a survey here: https://forms.gle/tMybKV9VrGRaTsrf9 Most important question (to people who have chimed in to this issue)
I voted "November" of course ! |
FYI to anyone following along, here's a writeup of our plans: https://docs.google.com/document/d/1miIu85DEkyR1MsenU5eYgBQk9i50UP1u6_Rp16fMOAg/edit |
@jamesagnew is there a public branch available where one can check out the amount of changes needed to one's own use of HAPI FHIR (I'm specifically thinking of the starter project as guinea pig here) |
@jkiddo The working branch for this change is |
Best news ever! |
FYI an update has been posted here: https://groups.google.com/g/hapi-fhir/c/U6dXYsC7LCg/m/N1Q752evBAAJ |
FYI we are now in review for this change. Our intention is to merge this after our November release. This is now feature complete, but because of transitive dependencies on JAXB, it requires coordination with CQL/CR projects. The following two projects must be built locally for now. This will change in the coming weeks: |
@jamesagnew thanks a lot for the update. do we know when the November release is going to happen? like an estimated date? |
@s4l4r The November Release is coming out on Thursday, Nov. 16th |
@jamesagnew thanks for the news! Do you have forecast for the next one with the merge? |
Since the intent of merging this with the november release will not happen. It's starting to become an issue for us to be late on our Spring updates |
@MatonAnthony Yes, James stated above: "Our intention is to merge this after our November release." |
This has now landed. HAPI FHIR 6.11.5-SNAPSHOT and later are using the new Jakarta APIs. This will be released as HAPI FHIR 7.0.0 in Feb 2024. JPA users can test this out using the branch in this PR: hapifhir/hapi-fhir-jpaserver-starter#618 |
Is there currently and play or timeline for the migration of code like https://github.com/jamesagnew/hapi-fhir/blob/9711b5ed1876e1566435a86873be5ee40f0ffc62/hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/server/RestfulServer.java#L76
from javax to jakarta?
Servers such as Tomcat and Jetty now have beta versions out that have the change made, but I don't believe any of them support deploying code that is still using javax (though I would be happy to be wrong...). Tomcat suggests a migration tool to help in the transition: https://github.com/apache/tomcat-jakartaee-migration
The text was updated successfully, but these errors were encountered: