Fix the build for Expecto.BenchmarkDotNet.Tests #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. I agree that we'd at least want it building. |
|
I just recalled that something similar happened in FSharpLint where a BenchmarkDotNet project was silently broken due to not being compiled in the CI builds - fsprojects/FSharpLint#620 - so best to build things to avoid that situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hadn't realised before, but it looks like the Expecto.BenchmarkDotNet.Tests test project isn't actually being built by the CI build - there are warnings in the build about not finding any projects to restore, e.g.
https://github.com/haf/expecto/actions/runs/10412005602/job/28836955136#step:4:355
And running it directly fails with an error about
runTestsInAssemblynot being found.I don't know about the history of this project (maybe you don't actually want to run benchmarks during the CI build?) - but it seems wrong to not at least compile it?