Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Expecto.BenchmarkDotNet.Tests during the build #507

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Aug 18, 2024

Refs #506 (comment)

The extra tests don't take very long on my laptop, so lets see how the CI does

@farlee2121
Copy link
Collaborator

Looks like it added about a minute to the build. That's a fairly high percentage increase, but I'd say still definitely in the realm of a running on every CI build.
At the same time, I'd say it's probably worth separating this out of the default local build

@Numpsy
Copy link
Contributor Author

Numpsy commented Aug 23, 2024

I've moved the BDN tests into a separate FAKE target called RunBenchmarkDotNetTest so that the regular unit tests can be run without running those, but as it stands the default target for local builds is 'All' so it still runs them by default locally

@farlee2121
Copy link
Collaborator

Ah. I didn't think about the dependency knot in target order. It'd be good to have it run before pack, but pack is part of the local build.

I'll go ahead an merge it for now. We can re-think the local build if it becomes a burden

@farlee2121 farlee2121 merged commit 876580a into haf:main Aug 24, 2024
2 checks passed
@Numpsy Numpsy deleted the run_bdn_tests branch August 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants