-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow psd var sample rate to change as needed #4541
Merged
bhooshan-gadre
merged 4 commits into
gwastro:master
from
bhooshan-gadre:psd_var_sample_rate
Oct 30, 2023
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e75c49c
Use same sample rate as strain for PSD variation instead of hardcoded…
c73b541
make srate int
0326a7a
strain is already preprocessed (resampled to requested sample rate vi…
d5eb70d
Removing unused resample to make codeclimate happy in variation.py
bhooshan-gadre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I check: wouldn't
strain
here already be at theopt.sample_rate
? What sample rate would it have if notopt.sample_rate
? Do I not achieve the same thing by just removing theresample_to_delta_t
line?@Moz-Port has left academia now, but I'm not aware of any reason why this was resampled specifically to 2048Hz ... I hope there's not a particular reason why this needs doing that we're missing ???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes! We don't need to resample it again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit rusty but I don't think removing the resampling will cause any problem.
When I first wrote this I was often using this code as a script to analyze raw data, so it must be a relic from my initial project.