allow psd var sample rate to change as needed #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2023 05:36
spxiwh
reviewed
Oct 24, 2023
pycbc/psd/variation.py
Outdated
|
|
||
| # Resample the data | ||
| strain = resample_to_delta_t(strain, 1.0 / 2048) | ||
| srate = int(strain.sample_rate) | ||
| strain = resample_to_delta_t(strain, 1. / srate) |
There was a problem hiding this comment.
Can I check: wouldn't strain here already be at the opt.sample_rate? What sample rate would it have if not opt.sample_rate? Do I not achieve the same thing by just removing the resample_to_delta_t line?
@Moz-Port has left academia now, but I'm not aware of any reason why this was resampled specifically to 2048Hz ... I hope there's not a particular reason why this needs doing that we're missing ???
There was a problem hiding this comment.
Oh yes! We don't need to resample it again!
There was a problem hiding this comment.
I'm a bit rusty but I don't think removing the resampling will cause any problem.
When I first wrote this I was often using this code as a script to analyze raw data, so it must be a relic from my initial project.
…a opts) so it is not even needed. Does PSD var really need fixed sample rate of 2048?
spxiwh
approved these changes
Oct 30, 2023
PRAVEEN-mnl
pushed a commit
to PRAVEEN-mnl/pycbc
that referenced
this pull request
Nov 3, 2023
* Use same sample rate as strain for PSD variation instead of hardcoded 2048 Hz * make srate int * strain is already preprocessed (resampled to requested sample rate via opts) so it is not even needed. Does PSD var really need fixed sample rate of 2048? * Removing unused resample to make codeclimate happy in variation.py --------- Co-authored-by: Bhooshan Gadre <[email protected]>
maxtrevor
pushed a commit
to maxtrevor/pycbc
that referenced
this pull request
Dec 11, 2023
* Use same sample rate as strain for PSD variation instead of hardcoded 2048 Hz * make srate int * strain is already preprocessed (resampled to requested sample rate via opts) so it is not even needed. Does PSD var really need fixed sample rate of 2048? * Removing unused resample to make codeclimate happy in variation.py --------- Co-authored-by: Bhooshan Gadre <[email protected]>
bhooshan-gadre
added a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Dec 19, 2023
* Use same sample rate as strain for PSD variation instead of hardcoded 2048 Hz * make srate int * strain is already preprocessed (resampled to requested sample rate via opts) so it is not even needed. Does PSD var really need fixed sample rate of 2048? * Removing unused resample to make codeclimate happy in variation.py --------- Co-authored-by: Bhooshan Gadre <[email protected]>
lpathak97
pushed a commit
to lpathak97/pycbc
that referenced
this pull request
Mar 13, 2024
* Use same sample rate as strain for PSD variation instead of hardcoded 2048 Hz * make srate int * strain is already preprocessed (resampled to requested sample rate via opts) so it is not even needed. Does PSD var really need fixed sample rate of 2048? * Removing unused resample to make codeclimate happy in variation.py --------- Co-authored-by: Bhooshan Gadre <[email protected]>
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Use same sample rate as strain for PSD variation instead of hardcoded 2048 Hz * make srate int * strain is already preprocessed (resampled to requested sample rate via opts) so it is not even needed. Does PSD var really need fixed sample rate of 2048? * Removing unused resample to make codeclimate happy in variation.py --------- Co-authored-by: Bhooshan Gadre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample rate of 2028 was hardcoded in the PSD var calculation. This was an issue if we wanted to use a different sample rate!