Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add override keyword in functions (OZ N-09) #1039

Merged
merged 1 commit into from
Sep 20, 2024
+5 −5
Merged

fix: add override keyword in functions (OZ N-09) #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/horizon/contracts/data-service/extensions/DataServicePausable.sol
View file
Original file line number Diff line number Diff line change
@@ -30,14 +30,14 @@ abstract contract DataServicePausable is Pausable, DataService, IDataServicePaus
/**
* @notice See {IDataServicePausable-pause}
*/
function pause() external onlyPauseGuardian whenNotPaused {
function pause() external override onlyPauseGuardian whenNotPaused {
_pause();
}

/**
* @notice See {IDataServicePausable-pause}
*/
function unpause() external onlyPauseGuardian whenPaused {
function unpause() external override onlyPauseGuardian whenPaused {
_unpause();
}

4 changes: 2 additions & 2 deletions packages/horizon/contracts/data-service/extensions/DataServicePausableUpgradeable.sol
View file
Original file line number Diff line number Diff line change
@@ -26,14 +26,14 @@ abstract contract DataServicePausableUpgradeable is PausableUpgradeable, DataSer
/**
* @notice See {IDataServicePausable-pause}
*/
function pause() external onlyPauseGuardian whenNotPaused {
function pause() external override onlyPauseGuardian whenNotPaused {
_pause();
}

/**
* @notice See {IDataServicePausable-pause}
*/
function unpause() external onlyPauseGuardian whenPaused {
function unpause() external override onlyPauseGuardian whenPaused {
_unpause();
}

2 changes: 1 addition & 1 deletion packages/subgraph-service/contracts/SubgraphService.sol
View file
Original file line number Diff line number Diff line change
@@ -351,7 +351,7 @@ contract SubgraphService is
/**
* @notice See {ISubgraphService.setRewardsDestination}
*/
function setRewardsDestination(address rewardsDestination) external {
function setRewardsDestination(address rewardsDestination) external override {
_setRewardsDestination(msg.sender, rewardsDestination);
}