Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add override keyword in functions (OZ N-09) #1039

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

MoonBoi9001
Copy link
Member

Motivation:

Title:

N-09 Missing override Keyword in Functions

Details:

Throughout the codebase, multiple instances of functions lacking the override keyword were identified:

The pause and unpause functions of the DataServicePausable contract
The pause and unpause functions of the DataServicePausableUpgradeable contract
The setRewardsDestination function of the SubgraphService contract
Functions that override the base contract functions ought to have the override keyword. Otherwise, it can be confusing for readers and developers, leading to potential misunderstandings about a function's origin and behavior. As such, consider using the override keyword for all functions that override base contract functions to enhance code readability and clarity.

Key changes

  • Added the override keyword to the functions outlined, applying the recommended fixes.

@MoonBoi9001 MoonBoi9001 requested a review from tmigone September 18, 2024 16:30
Copy link

fix: add override keyword in functions (OZ N-09)

Generated at commit: 516a4e3bf2841d5ed764183e48e25df0a5dfc799

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
41
62
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MoonBoi9001 MoonBoi9001 merged commit f2a5498 into horizon Sep 20, 2024
9 checks passed
@MoonBoi9001 MoonBoi9001 deleted the fix_oz_n-09 branch September 20, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants