Add chat member filters #10
Open
+1,022
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roziscoding
previously approved these changes
Jan 28, 2025
KnorpelSenf
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Implementation looks great!
Regarding the docs: It's awesome to have such great descriptions, but they are not duplicated in the repo and the website. In general, we tend to only give very short quickstarts in the README files and link to the website for everything else. This makes sure that the docs don't start to diverge and it also reduces the maintenance overhead.
You may or may not remove them, do whatever you think is best. That being said, you might want to save the effort in the future.
I just have a few nitpicks, the changes LGTM otherwise:
Co-authored-by: KnorpelSenf <[email protected]>
KnorpelSenf
previously approved these changes
Jan 30, 2025
There was a problem hiding this comment.
LGTM after you and @roziscoding have figured out how to prevent line wrapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds chat member filters to the plugin, a convenient way to filter for chat member statuses and updates.
I moved the original code to a separate
storage.tsfile and created afilters.tsfile containing the new filters, everything is exported frommod.ts.I updated the README to explain how the new filters can be used.