Updated documentation for chat-members plugin, adding new sections about filters #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out chat member filters
|
🚀 Deployed on https://67a4d369e792481cb5477ac8--grammy.netlify.app |
KnorpelSenf
requested changes
Jan 23, 2025
KnorpelSenf
reviewed
Jan 29, 2025
| bot.callbackQuery("foo", async (ctx) => { | ||
| const chatMember = await ctx.getChatMember(ctx.from.id); | ||
|
|
||
| if (!chatMemberIs(chatMember, "free")) { |
There was a problem hiding this comment.
Unrelated to the docs but the plugin could use a hydration feature that permits
Suggested change
| if (!chatMemberIs(chatMember, "free")) { | |
| if (!chatMember.is("free")) { |
There was a problem hiding this comment.
That's a very nice idea! They could be added for getChatMember and getChatAdministrators.
I already have a draft of the types (kinda messy right now but I'll work on them) and they seem to work.
|
@roziscoding anything else? |
not at all, this looks great! |
roziscoding
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds documentation for chat member filters in the chat-members plugin section.
grammyjs/chat-members#10
Let me know if the paragraph structure or anything else could be improved.