Alloy-Mixin: allow k8s cluster and alloy cluster disable, add logs dashboard #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfratto
reviewed
May 23, 2024
rfratto
reviewed
May 23, 2024
|
|
||
| local labels = if $._config.enableK8sCluster then ['cluster', 'namespace', 'job', 'instance', 'level'] else ['job', 'instance', 'level'], | ||
|
|
||
| grafanaDashboards+: |
There was a problem hiding this comment.
This doesn't seem to follow the pattern that other dashboards do; this is the only one with a grafanaDashboards top-level key. Can we change this to be consistent with the other dashboards?
That would also mean moving the logic for whether to enable the dashboard outside of the definition of the dashboard itself, which would be more consistent with how the clustering dashboards are made optional.
There was a problem hiding this comment.
That is because the library I am using expects a grafanaDashboards variable.
I also don't like how it looks different, but since this is a totally different library which is synced with the latest version of grafonnet, I believe it is an acceptable trade off.
rfratto
approved these changes
May 24, 2024
rfratto
added a commit
to rfratto/alloy
that referenced
this pull request
May 28, 2024
grafana#808 introduced dependencies for the mixin, which accidentally broke the example environment; as the mixin originally didn't have dependencies, the example environment didn't install them before provisioning dashboards. This commit runs jb to locally install dependencies before provisioning dashboards.
rfratto
added a commit
that referenced
this pull request
May 28, 2024
#808 introduced dependencies for the mixin, which accidentally broke the example environment; as the mixin originally didn't have dependencies, the example environment didn't install them before provisioning dashboards. This commit runs jb to locally install dependencies before provisioning dashboards.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Introducing the following changes:
joblabel everywhere as a grouper whenclusterandnamespaceare disabled, to avoid metric conflicts - likeupmetricWhich issue(s) this PR fixes
Notes to the Reviewer
Let me know if this needs changelog updates or if there are any docs.
PR Checklist