-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alloy-Mixin: allow config overwrite #934
Conversation
@gaantunes While we're working through fixes for #808, I found a few other issues that PR introduced:
You can reproduce this locally if you navigate to the
then navigate to http://localhost:3000 for the Grafana instance it spawns. The Docker Compose environment also watches for changes to the mixin so you can test changes live. After you're done, you can tear it down with
|
@rfratto should be ready for a re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sorry, I had reviewed this last week but never submitted my review 😞)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is coming along well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the diffs in our internal deployment of the mixin, looks good. Thanks!
PR Description
Implementing the following changes:
grafanaDashboards
andprometheusAlerts
hidden, according to the mixin schema.job="integrations/self"
service_name="alloy"
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist