Skip to content
This repository has been archived by the owner on Oct 29, 2023. It is now read-only.

Update analyze_variants_with_bigquery.rst to use Standard SQL #143

Merged
merged 3 commits into from
Jan 26, 2017
Merged

Update analyze_variants_with_bigquery.rst to use Standard SQL #143

merged 3 commits into from
Jan 26, 2017

Conversation

mbookman
Copy link
Contributor

instead of Legacy SQL.

@mbookman
Copy link
Contributor Author

Rendered output staged at:

Staged to:
http://googlegenomics.readthedocs.io/en/staging-2/use_cases/analyze_variants/analyze_variants_with_bigquery.html

deflaux
deflaux approved these changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@deflaux deflaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow - this is a really excellent tutorial @mbookman

It does a fantastic job covering various commons filtering scenarios.

LVeryGTM

docs/source/use_cases/analyze_variants/analyze_variants_with_bigquery.rst
Two of the fields noted above, the ``alternate_bases`` and the ``call``
field, are REPEATED fields. REPEATED fields are a feature of BigQuery
+-------------------------------------------------------------------------+
| Legacy SQL Nomenclature |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clarification

docs/source/use_cases/analyze_variants/analyze_variants_with_bigquery.rst
FROM
`genomics-public-data.platinum_genomes.variants`

returns the ``number_of_calls`` as 261,285,806. Notice that this is the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe bold or underline "Notice ..."

docs/source/use_cases/analyze_variants/analyze_variants_with_bigquery.rst
+------------------------------------------------------------------------+
| Code tip: UNNEST |
+========================================================================+
| The `UNNEST`_ function provides a mechanism to query over an ARRAY |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clarification

@mbookman mbookman merged commit 73c9de0 into master Jan 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deflaux deflaux deflaux approved these changes

Assignees

@deflaux deflaux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbookman @deflaux