add vertex specific count token request #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlazo
reviewed
Jun 4, 2024
| @@ -41,3 +41,11 @@ data class GenerateContentRequest( | |||
| @Serializable | |||
| data class CountTokensRequest(@Transient val model: String? = null, val contents: List<Content>) : | |||
| Request | |||
|
|
|||
| @Serializable | |||
There was a problem hiding this comment.
An alternative that reduces code changes is this:
- Make
CountTokenRequestcontain the superset of fields - Add two builder methods, one for generativeai that only accepts
GenerateContentRequestand one for vertex that only accepts the fields supported by Vertex. - When creating the field, only fill the right fields
Since fields not included are not encoded, then nothing else in the code needs to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.