Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire through new countTokenRequest #6011

Closed
wants to merge 6 commits into from
Closed

wire through new countTokenRequest #6011

wants to merge 6 commits into from

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@davidmotson davidmotson requested a review from rlazo June 3, 2024 22:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 3, 2024 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (b770489) and merge commit (20ab67a).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QrPw46yELA.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024 •
edited
Loading

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 67fea4f. ± Comparison against base commit b770489.

♻️ This comment has been updated with latest results.

rlazo
rlazo reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@rlazo rlazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See google-gemini/generative-ai-android#171 (comment)

@davidmotson davidmotson deleted the davidmotson.vertex_count_token branch June 12, 2024 20:54
davidmotson pushed a commit that referenced this pull request Jun 12, 2024
add changes from #6011
3edae05
@firebase firebase locked and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo left review comments

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmotson @google-oss-bot @rlazo