Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Aligning minimal delegation score to 15 & delegation message in FE #626

Merged
merged 3 commits into from
Jan 10, 2025
Merged

HOTFIX: Aligning minimal delegation score to 15 & delegation message in FE #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee584e7
Aligning minimal delegation score to 15
adam-gf Jan 10, 2025
b334d66
update tests
adam-gf Jan 10, 2025
ff0406b
Update FE delegation signing format
adam-gf Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/app/modules/score_delegation/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from app.modules.common.delegation import HashedAddresses, hash_addresses
from app.modules.dto import ScoreDelegationPayload

MIN_SCORE = 20
MIN_SCORE = 15


class ActionType(Enum):
Expand Down
2 changes: 1 addition & 1 deletion backend/tests/modules/score_delegation/test_score_delegation_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def test_score_is_too_low():
core.verify_score_delegation(
hashed_addresses,
set(),
19.9,
14.9,
0,
core.ActionType.DELEGATION,
USER1_ADDRESS,
Expand Down
2 changes: 1 addition & 1 deletion ...ts/Home/HomeGridUQScore/ModalCalculatingUQScore/CalculatingUQScore/CalculatingUQScore.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const CalculatingUQScore: FC<CalculatingUQScoreProps> = ({ setShowCloseButton })
);

// Message needs to stay in English regardless of locale, as it's content is verified in BE.
const messageToSign = ` "Delegation of UQ score from ${delegationSecondaryAddress} to ${delegationPrimaryAddress}`;
const messageToSign = `Delegation of UQ score from ${delegationSecondaryAddress} to ${delegationPrimaryAddress}`;

const isScoreHighlighted = !!(lastDoneStep && lastDoneStep >= 1);
const showLowScoreInfo =
Expand Down