Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Aligning minimal delegation score to 15 & delegation message in FE #626

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

adam-gf
Copy link
Contributor

@adam-gf adam-gf commented Jan 10, 2025

Description

Lowers the minimal uq score required to make a delegation

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

kgarbacinski
kgarbacinski previously approved these changes Jan 10, 2025
@adam-gf adam-gf self-assigned this Jan 10, 2025
@adam-gf adam-gf added the request-approval Request approval from the Housekeeper label Jan 10, 2025
Copy link
Contributor

@kgarbacinski kgarbacinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls make sure it's branched from the current master; if yes - then lgtm

@aziolek aziolek merged commit 3333bc2 into master Jan 10, 2025
38 checks passed
@aziolek aziolek deleted the hotfix-align-minimal-delegation-score branch January 10, 2025 19:27
@aziolek aziolek changed the title HOTFIX: Aligning minimal delegation score to 15 HOTFIX: Aligning minimal delegation score to 15 & delegation message in FE Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request-approval Request approval from the Housekeeper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants