Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1825: Initial passthrough FastAPI server (rebased) #525

Merged
merged 26 commits into from
Oct 21, 2024

Conversation

adam-gf
Copy link
Contributor

@adam-gf adam-gf commented Oct 21, 2024

Description

Adds FastAPI as the main application.
Mounts old flask app under /flask.
If route does not exist in FastAPI it's routed to old implementation under flask.
Rewrites socketio connection handling in FastAPI directly (using async).
Fixes the socketio manager to share sessions via redis.

Definition of Done

  1. If required, the desciption of your change is added to the QA changelog
  2. Acceptance criteria are met.
  3. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  4. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  5. Unit tests are added unless there is a reason to omit them.
  6. Automated tests are added when required.
  7. The code is merged.
  8. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  9. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

Copy link

linear bot commented Oct 21, 2024

@housekeeper-bot housekeeper-bot temporarily deployed to uat October 21, 2024 12:40 Destroyed
@adam-gf adam-gf self-assigned this Oct 21, 2024
@adam-gf adam-gf added the request-approval Request approval from the Housekeeper label Oct 21, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Oct 21, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #11440458323 passed 🎉

Copy link
Member

@mslomnicki mslomnicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as rebased #379

@adam-gf adam-gf merged commit c6c0039 into develop Oct 21, 2024
56 of 62 checks passed
@adam-gf adam-gf deleted the adam/oct-1825-rebased branch October 21, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants