Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCT-1825: Initial passthrough FastAPI server #379

Closed

Conversation

adam-gf
Copy link
Contributor

@adam-gf adam-gf commented Aug 5, 2024

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

@adam-gf adam-gf marked this pull request as ready for review August 27, 2024 19:14
@0xartem 0xartem self-requested a review September 2, 2024 10:10
Copy link
Member

@0xartem 0xartem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the code. it all looks good to me without going much into the details. I never worked with Fast API.
Questions:

  • did we re-write all the back-end requests via Fast API?
  • how do we test the improvements during the testing? Perfomance etc.

@housekeeper-bot housekeeper-bot temporarily deployed to master October 6, 2024 19:43 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master October 6, 2024 20:00 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master October 7, 2024 08:28 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master October 7, 2024 08:45 Destroyed
…thub-golem:golemfoundation/octant into adam/oct-1825-initial-passthrough-fastapi-server
@housekeeper-bot housekeeper-bot temporarily deployed to master October 7, 2024 09:07 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master October 7, 2024 09:38 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master October 7, 2024 09:57 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to master October 7, 2024 13:13 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat October 15, 2024 13:18 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat October 15, 2024 13:56 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat October 15, 2024 20:35 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat October 16, 2024 09:06 Destroyed
@adam-gf adam-gf requested a review from kgarbacinski October 17, 2024 09:50
Copy link
Contributor

@kgarbacinski kgarbacinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general - LGTM, have you also checked with Mati the corectness of functionality within Flask endpoints only (whether the middlewared views save correct data to the db etc.)?

backend/app/__init__.py Show resolved Hide resolved
backend/app/settings.py Outdated Show resolved Hide resolved
backend/v2/allocations/dependencies.py Outdated Show resolved Hide resolved
backend/v2/allocations/dependencies.py Show resolved Hide resolved
backend/v2/allocations/schemas.py Outdated Show resolved Hide resolved
backend/v2/epochs/dependencies.py Outdated Show resolved Hide resolved
backend/v2/core/dependencies.py Outdated Show resolved Hide resolved
backend/v2/main.py Outdated Show resolved Hide resolved
@housekeeper-bot housekeeper-bot temporarily deployed to uat October 18, 2024 10:50 Destroyed
@housekeeper-bot housekeeper-bot temporarily deployed to uat October 18, 2024 10:53 Destroyed
Copy link
Contributor

@kgarbacinski kgarbacinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as the first stage, let's focus on all remaining pains before getting started with another functionalities

@adam-gf adam-gf added the request-approval Request approval from the Housekeeper label Oct 21, 2024
@housekeeper-bot housekeeper-bot removed the request-approval Request approval from the Housekeeper label Oct 21, 2024
Copy link
Contributor

@housekeeper-bot housekeeper-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E job #11438762470 passed 🎉

@adam-gf
Copy link
Contributor Author

adam-gf commented Oct 21, 2024

Due to problems with rebasing et al. We simply moved changes to separate pr and merged that one: #525.
Closing as it's resolved

@adam-gf adam-gf closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants