-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCT-1825: Initial passthrough FastAPI server #379
OCT-1825: Initial passthrough FastAPI server #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the code. it all looks good to me without going much into the details. I never worked with Fast API.
Questions:
- did we re-write all the back-end requests via Fast API?
- how do we test the improvements during the testing? Perfomance etc.
…thub-golem:golemfoundation/octant into adam/oct-1825-initial-passthrough-fastapi-server
…thub-golem:golemfoundation/octant into adam/oct-1825-initial-passthrough-fastapi-server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general - LGTM, have you also checked with Mati the corectness of functionality within Flask endpoints only (whether the middlewared views save correct data to the db etc.)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as the first stage, let's focus on all remaining pains before getting started with another functionalities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E job #11438762470 passed 🎉
Due to problems with rebasing et al. We simply moved changes to separate pr and merged that one: #525. |
Description
Definition of Done
(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.
(2) Octant Areas & Test Cases.