Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-OCT-1572: Ignore errors when 404 #167

Merged
merged 1 commit into from
Apr 19, 2024
Merged

FIX-OCT-1572: Ignore errors when 404 #167

merged 1 commit into from
Apr 19, 2024

Conversation

kgarbacinski
Copy link
Contributor

Description

Definition of Done

  1. Acceptance criteria are met.
  2. PR is manually tested before the merge by developer(s).
    • Happy path is manually checked.
  3. PR is manually tested by QA when their assistance is required (1).
    • Octant Areas & Test Cases are checked for impact and updated if required (2).
  4. Unit tests are added unless there is a reason to omit them.
  5. Automated tests are added when required.
  6. The code is merged.
  7. Tech documentation is added / updated, reviewed and approved (including mandatory approval by a code owner, should such exist for changed files).
    • BE: Swagger documentation is updated.
  8. When required by QA:
    • Deployed to the relevant environment.
    • Passed system tests.

(1) Developer(s) in coordination with QA decide whether it's required. For small tickets introducing small changes QA assistance is most probably not required.

(2) Octant Areas & Test Cases.

leoni-q
leoni-q previously approved these changes Apr 19, 2024
@leoni-q
Copy link
Contributor

leoni-q commented Apr 19, 2024

Shouldn't go to master?

@leoni-q leoni-q changed the base branch from develop to master April 19, 2024 06:46
@leoni-q leoni-q dismissed their stale review April 19, 2024 06:46

The base branch was changed.

@kgarbacinski kgarbacinski merged commit 7329109 into master Apr 19, 2024
45 checks passed
@kgarbacinski kgarbacinski deleted the fix/oct-1572 branch April 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants