Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-OCT-1572: Ignore errors when 404 #167

Merged
merged 1 commit into from
Apr 19, 2024
Merged

FIX-OCT-1572: Ignore errors when 404 #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions backend/app/modules/multisig_signatures/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import json
from http import HTTPStatus
from typing import List, Tuple, Dict

from eth_account.messages import SignableMessage

from app.exceptions import ExternalApiException
from app.infrastructure.database.models import MultisigSignatures
from app.infrastructure.external_api.safe.message_details import get_message_details
from app.infrastructure.external_api.safe.user_details import get_user_details
Expand Down Expand Up @@ -62,17 +64,20 @@ def approve_pending_signatures(
approved_signatures.append(_create_signature_object(pending_signature))
continue

message_details = get_message_details( # TODO extract API call to service
pending_signature.msg_hash, is_mainnet=is_mainnet
)
confirmations = message_details["confirmations"]
threshold = int(
get_user_details(
try:
message_details = get_message_details( # TODO extract API call to service
pending_signature.msg_hash, is_mainnet=is_mainnet
)
user_details = get_user_details(
pending_signature.address, is_mainnet=is_mainnet
)[ # TODO extract API call to service
"threshold"
]
)
) # TODO extract API call to service
except ExternalApiException as e:
if e.status_code == HTTPStatus.NOT_FOUND:
continue
raise e

confirmations = message_details["confirmations"]
threshold = int(user_details["threshold"])

if len(confirmations) >= threshold:
pending_signature.confirmed_signature = message_details["preparedSignature"]
Expand Down