Skip to content

Commit

Permalink
FIX-OCT-1572: Ignore errors when 404
Browse files Browse the repository at this point in the history
  • Loading branch information
kgarbacinski committed Apr 18, 2024
1 parent 865f2ae commit a27ee40
Showing 1 changed file with 14 additions and 10 deletions.
24 changes: 14 additions & 10 deletions backend/app/modules/multisig_signatures/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
)
from app.modules.dto import SignatureOpType
from app.modules.multisig_signatures.dto import Signature
from app.exceptions import ExternalApiException


def prepare_msg_to_save(message: str | dict, op_type: SignatureOpType) -> str:
Expand Down Expand Up @@ -62,17 +63,20 @@ def approve_pending_signatures(
approved_signatures.append(_create_signature_object(pending_signature))
continue

message_details = get_message_details( # TODO extract API call to service
pending_signature.msg_hash, is_mainnet=is_mainnet
)
confirmations = message_details["confirmations"]
threshold = int(
get_user_details(
try:
message_details = get_message_details( # TODO extract API call to service
pending_signature.msg_hash, is_mainnet=is_mainnet
)
user_details = get_user_details(
pending_signature.address, is_mainnet=is_mainnet
)[ # TODO extract API call to service
"threshold"
]
)
) # TODO extract API call to service
except ExternalApiException as e:
if e.status_code == 404:
continue
raise e

confirmations = message_details["confirmations"]
threshold = int(user_details["threshold"])

if len(confirmations) >= threshold:
pending_signature.confirmed_signature = message_details["preparedSignature"]
Expand Down

0 comments on commit a27ee40

Please sign in to comment.