Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh pages korean #62

Closed
wants to merge 41 commits into from
Closed

Gh pages korean #62

wants to merge 41 commits into from

Conversation

liks79
Copy link

@liks79 liks79 commented Jul 21, 2013

Korean translation of choosealicense.com

Hello.
I think the contents of 'choosealicense.com' are very simple and easy.
It is wonderful!
So, I translated choosealicense.com in Korean.
I made a new branch "gh-pages-korean" for Korean translation.
I've finished translation.

I hope choosalicense.com support Korean.

Please review my work and give me some information how to merge master branch or your plan about support multi-lingual.

Thanks.

@liks79
Copy link
Author

liks79 commented Jul 22, 2013

If you want to see translation result, visit following url.

http://liks79.github.io/choosealicense.com

@@ -19,7 +21,7 @@ permitted:
- distribution

forbidden:
- no-liability
- no-liabilityThe Free Software Foundation recommends taking the additional step of adding a boilerplate notice to the top of each file. The boilerplate can be found at the end of the license.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh,... I'm Sorry..
It's my mistake!
I'll be remove it!

Thanks

@benbalter
Copy link
Contributor

Awesome, awesome stuff. Would love to figure out the best way to integrate this going forward (#68).

@@ -1,26 +1,40 @@
<div class='sidebar'>

<a href="#" data-clipboard-target="license-text" class="js-clipboard-button button">Copy license text to clipboard</a>
<a href="#" data-clipboard-target="license-text" class="js-clipboard-button button">라이선스를 클립보드에 복사</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this button is clicked, the text of the button becomes to 'Copied!' (which is not translated).

I guess the following line in app.coffee need translatation:

@innerText = "Copied!"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeahh!
That's right.
I'll apply it.

Thanks!

@haacked
Copy link
Contributor

haacked commented Oct 29, 2013

Closing this. This would simply translate our existing site to Korean and overwrite the English! We need a better approach for translations. I opened an issue here: #112

@haacked haacked closed this Oct 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants