Build system

[daniel-noland]

basically the whole project up to this point. looking to squash and start clean after this lands

[qmonnet]

A few fixes are necessary, as per the discussion above, so I'm turning my review status into “Request changes”.

[daniel-noland]

A few fixes are necessary, as per the discussion above, so I'm turning my review status into “Request changes”.

I think I have addressed everything you discussed before. Let me know what you think

[qmonnet]

Looks good, awesome work! 🚀

The PR is too big to really dig into the details. I pulled the changes and validated that I can still build and pass the tests with both glibc/musl (Note that I get a few warnings for the tests). I'd normally complain that this needs to be split up into logical commits, but I understand the plan is to wipe the Git history so far anyway.

I've got a few nits below, but we can address them as follow-ups. I think we should go ahead and merge this PR, we can do some more polishing afterwards.

[qmonnet]

This comment seems copy-pasted from dev.yml but I don't think it applies to this workflow.

[qmonnet]

Next step: We need a cool logo :)

This comment hasn't been addressed 😛

[qmonnet]

Note: I have a follow-up PR based on yours, and some of the sterile.yml / push checks are failing (https://github.com/githedgehog/dataplane/actions/runs/11743968718/job/32717988208?pr=62)

[qmonnet]

checks are failing

ERROR: invalid tag "ghcr.io/githedgehog/dataplane:2024-11-08.pr/license.x86_64-unknown-linux-gnu.debug.f940553fe3b427a4b71fcf5df3837b8f17ed63ca": invalid reference format

I think this is because I used a / in my branch name for the PR (I used pr/license). We need to sanitize the branch name before using it in a container tag, here in the justfile:

_branch := `git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "sterile"`

[qmonnet]

I've got a fix for this branch name thing:

diff --git a/justfile b/justfile
index d87adb36099a..2c9be0c97c4c 100644
--- a/justfile
+++ b/justfile
@@ -66,7 +66,7 @@ _commit := `git rev-parse HEAD 2>/dev/null || echo "sterile"`
 # The git branch we are currnetly on
 # We allow this command to fail in the sterile environment because git is not available there
 
-_branch := `git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "sterile"`
+_branch := `(git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "sterile") | tr -c '[:alnum:]\n' '-'`
 
 # The git tree state (clean or dirty)
 # We allow this command to fail in the sterile environment because git is not available there

I'll do a follow-up PR after your branch is merged.

[daniel-noland]

I've got a fix for this branch name thing:

diff --git a/justfile b/justfile
index d87adb36099a..2c9be0c97c4c 100644
--- a/justfile
+++ b/justfile
@@ -66,7 +66,7 @@ _commit := `git rev-parse HEAD 2>/dev/null || echo "sterile"`
 # The git branch we are currnetly on
 # We allow this command to fail in the sterile environment because git is not available there
 
-_branch := `git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "sterile"`
+_branch := `(git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "sterile") | tr -c '[:alnum:]\n' '-'`
 
 # The git tree state (clean or dirty)
 # We allow this command to fail in the sterile environment because git is not available there

I'll do a follow-up PR after your branch is merged.

nice