justfile: Sanitize branch names before using them in container tags #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the branch name as part of containers tags fails when branch names
contain characters that are not valid for container tags (or not valid
at the location where we use the branch name in the tag string).
To prevent the CI workflow from failing when the Pull Request branch
name contains a slash, for example, sanitize the branch name before
using it.
We sanitize it by translating ('tr') everything that is not ('-c') an
alphanumeric character ('[:alnum:]') or a line break ('\n') into dashes.
We keep line breaks because we don't want the final line break appended
by echo to be converted into a dash; assigning the string to '_branch'
will trim the ending line break anyway.
Fixes: b88ec42 ("Build system")
Signed-off-by: Quentin Monnet <[email protected]>
|
CI check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the branch name as part of containers tags fails when branch names contain characters that are not valid for container tags (or not valid at the location where we use the branch name in the tag string).
To prevent the CI workflow from failing when the Pull Request branch name contains a slash, for example, sanitize the branch name before using it.
We sanitize it by translating (
tr) everything that is not (-c) an alphanumeric character ([:alnum:]) or a line break (\n) into dashes. We keep line breaks because we don't want the final line break appended by echo to be converted into a dash; assigning the string to_branchwill trim the ending line break anyway.Fixes: #21