-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman: Update to v5.3.1 and Update podman dependencies #4771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that devmapper
is no longer in the abi_used_libs
list. Is it still needed during the build?
Uh, good question. I'll take a look at the other change logs. Distrobox didn't really seem to care. |
So I couldn't find anything in the release notes, but I found this. Not sure if it means that it is not needed at buildtime or runtime or both. |
Fedora doesn't list it as a dependency, either. In any case, |
Yeah, I just checked that too. Does anything else need to be updated? I checked the last pull request that had podman and there were a couple of other packages that were updated. |
It looks like in the past, |
Yeah there are some dependencies that need to be updated. I'll update them tomorrow. |
I know this is unrelated to your change, but |
I was not able to check for passt. I was not able to connect to their website to check if there was a new version. I did find a mirror but I am not sure if it is correct. |
@uni-dos My understanding is that the "Tag" section of https://passt.top/passt indicate a new release, so the latest release would be |
Ah, the website finally loaded. I'll add it right now after I fix netavark. |
Okay, everything should be up to date. I added the monitoring.yml to passt. Not sure if the rss part is correct though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested podman with pasta networking using host ollama connected to podman open-webui.
Thanks for the update!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only thing is that I'm pretty sure that the passt
RSS link in the monitoring.yml
file is not an actual RSS feed. I don't see anything that looks like an RSS feed in relation to that repo, so maybe it should just be set to ~
?
@uni-dos Seems like some changes in Other than that, I think this PR is good to go unless someone else have other concerns. |
@GZGavinZhao Please go for it. I was attempting to rebase it but my git reflog has other changes. |
**Summary** - update podman dependencies
**Summary** - update podaman dependency - update package.yml to allow building new version
**Summary** - update to latest version for podman - add monitoring.yml
**Summary** - update podman to latest version - latest [changelog](https://github.com/containers/podman/releases/tag/v5.3.1) - removed devmapper dependency Signed-off-by: Gavin Zhao <[email protected]>
fbb0b85
to
425b8fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Summary
Test Plan
Checklist
Resolves #4738