Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: Update to v5.3.1 and Update podman dependencies #4771

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

uni-dos
Copy link
Contributor

@uni-dos uni-dos commented Jan 8, 2025

Summary

  • update podman to latest version
  • latest changelog
  • Update skopeo
  • Update netavark
  • Update passt

Test Plan

  • launch distrobox contianer

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

Resolves #4738

Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that devmapper is no longer in the abi_used_libs list. Is it still needed during the build?

@uni-dos
Copy link
Contributor Author

uni-dos commented Jan 8, 2025

Uh, good question. I'll take a look at the other change logs. Distrobox didn't really seem to care.

@uni-dos
Copy link
Contributor Author

uni-dos commented Jan 9, 2025

So I couldn't find anything in the release notes, but I found this. Not sure if it means that it is not needed at buildtime or runtime or both.

@EbonJaeger
Copy link
Member

EbonJaeger commented Jan 9, 2025

Fedora doesn't list it as a dependency, either. In any case, pkgconfig(devmapper) on Solus is provided by the lvm2 package, which is in system.base, and lvm2-devel is in system-devel, so they'll always be present anyways, so it doesn't need to be specified in the package.yml. Let's remove that dependency, and double-check that everything works.

@uni-dos
Copy link
Contributor Author

uni-dos commented Jan 9, 2025

Yeah, I just checked that too. Does anything else need to be updated? I checked the last pull request that had podman and there were a couple of other packages that were updated.

@EbonJaeger
Copy link
Member

It looks like in the past, podman was updated along with the packages that it depends on. It might be worth checking to see if any of them have updates, excluding gpgme, glibc, lvm2, and iptables; those packages are more core system packages that you don't really want to touch. Note that the dependencies would have to be built before podman; see this Help Center Article if you aren't familiar with stack upgrades.

@uni-dos
Copy link
Contributor Author

uni-dos commented Jan 9, 2025

Yeah there are some dependencies that need to be updated. I'll update them tomorrow.

@uni-dos uni-dos changed the title podman: Update to v5.3.1 podman: Update to v5.3.1 and Update podman dependencies Jan 9, 2025
@GZGavinZhao
Copy link
Member

I know this is unrelated to your change, but netavark is installed in /usr/local when it really should be installed in /usr. If you want to, you can follow what I did in d795520 to correct this.

@uni-dos
Copy link
Contributor Author

uni-dos commented Jan 9, 2025

I was not able to check for passt. I was not able to connect to their website to check if there was a new version. I did find a mirror but I am not sure if it is correct.

@GZGavinZhao
Copy link
Member

@uni-dos My understanding is that the "Tag" section of https://passt.top/passt indicate a new release, so the latest release would be 2024_12_11.09478d5.

@uni-dos
Copy link
Contributor Author

uni-dos commented Jan 9, 2025

@uni-dos My understanding is that the "Tag" section of https://passt.top/passt indicate a new release, so the latest release would be 2024_12_11.09478d5.

Ah, the website finally loaded. I'll add it right now after I fix netavark.

@uni-dos
Copy link
Contributor Author

uni-dos commented Jan 9, 2025

Okay, everything should be up to date. I added the monitoring.yml to passt. Not sure if the rss part is correct though.

@uni-dos uni-dos requested a review from davidjharder January 9, 2025 21:41
@GZGavinZhao GZGavinZhao self-requested a review January 12, 2025 00:14
GZGavinZhao
GZGavinZhao previously approved these changes Jan 12, 2025
Copy link
Member

@GZGavinZhao GZGavinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested podman with pasta networking using host ollama connected to podman open-webui.

Thanks for the update!

packages/n/netavark/package.yml Outdated Show resolved Hide resolved
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only thing is that I'm pretty sure that the passt RSS link in the monitoring.yml file is not an actual RSS feed. I don't see anything that looks like an RSS feed in relation to that repo, so maybe it should just be set to ~ ?

@GZGavinZhao
Copy link
Member

@uni-dos Seems like some changes in netavark got mixed into the podman commit. Would you be fine with me force pushing to your branch to fix this?

Other than that, I think this PR is good to go unless someone else have other concerns.

@uni-dos
Copy link
Contributor Author

uni-dos commented Jan 14, 2025

@GZGavinZhao Please go for it. I was attempting to rebase it but my git reflog has other changes.

**Summary**
- update podman dependencies
**Summary**
- update podaman dependency
- update package.yml to allow building new version
**Summary**
- update to latest version for podman

- add monitoring.yml
**Summary**
- update podman to latest version
- latest [changelog](https://github.com/containers/podman/releases/tag/v5.3.1)
- removed devmapper dependency

Signed-off-by: Gavin Zhao <[email protected]>
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EbonJaeger EbonJaeger dismissed malfisya’s stale review January 15, 2025 01:07

Issue is resolved

@EbonJaeger EbonJaeger merged commit f14a428 into getsolus:main Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

update podman to 5.3.1
5 participants