feat(new-trace) Adding trace level ops breakdown #84354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abdkhan14
commented
Jan 31, 2025
Abdkhan14
commented
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #84354 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 9601 9601
Lines 543278 543278
Branches 21286 21286
=======================================
Hits 476034 476034
Misses 66891 66891
Partials 353 353 |
edwardgou-sentry
approved these changes
Jan 31, 2025
JonasBa
reviewed
Jan 31, 2025
static/app/views/performance/newTraceDetails/traceLevelOpsBreakdown.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceLevelOpsBreakdown.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceLevelOpsBreakdown.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/newTraceDetails/traceLevelOpsBreakdown.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| return ( | ||
| <Container> | ||
| {opsCountsResult?.data.slice(0, 4).map(currOp => { |
There was a problem hiding this comment.
Followed the designs here for it: https://www.figma.com/design/zfReOSQiHfODLLoFWpYVdW/Trace-V3?node-id=42-1924&t=tsKe9q2Uvr3vObN0-0
static/app/views/performance/newTraceDetails/traceLevelOpsBreakdown.tsx
Outdated
Show resolved
Hide resolved
Abdkhan14
force-pushed
the
abdk/trace-level-ops-breakdown
branch
from
6d73309 to
ec31195
Compare
andrewshie-sentry
pushed a commit
that referenced
this pull request
Feb 5, 2025
<img width="775" alt="Screenshot 2025-01-30 at 7 50 13 PM" src="https://github.com/user-attachments/assets/84209045-87b1-4432-af98-a09ad1f79b3c" /> -------------- <img width="694" alt="Screenshot 2025-01-30 at 7 50 21 PM" src="https://github.com/user-attachments/assets/f3e0a2d7-93ca-4e1d-91aa-5eb751afc058" /> --------- Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.