-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(new-trace) Adding trace level ops breakdown (#84354)
<img width="775" alt="Screenshot 2025-01-30 at 7 50 13 PM" src="https://github.com/user-attachments/assets/84209045-87b1-4432-af98-a09ad1f79b3c" /> -------------- <img width="694" alt="Screenshot 2025-01-30 at 7 50 21 PM" src="https://github.com/user-attachments/assets/f3e0a2d7-93ca-4e1d-91aa-5eb751afc058" /> --------- Co-authored-by: Abdullah Khan <[email protected]>
- Loading branch information
Showing
4 changed files
with
162 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
static/app/views/performance/newTraceDetails/traceLevelOpsBreakdown.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| import styled from '@emotion/styled'; | ||
|
|
||
| import {addErrorMessage} from 'sentry/actionCreators/indicator'; | ||
| import {pickBarColor} from 'sentry/components/performance/waterfall/utils'; | ||
| import Placeholder from 'sentry/components/placeholder'; | ||
| import {IconCircleFill} from 'sentry/icons/iconCircleFill'; | ||
| import {t} from 'sentry/locale'; | ||
| import {space} from 'sentry/styles/space'; | ||
| import type {NewQuery} from 'sentry/types/organization'; | ||
| import {useDiscoverQuery} from 'sentry/utils/discover/discoverQuery'; | ||
| import {DiscoverDatasets} from 'sentry/utils/discover/types'; | ||
| import type {Color} from 'sentry/utils/theme'; | ||
| import {useLocation} from 'sentry/utils/useLocation'; | ||
| import useOrganization from 'sentry/utils/useOrganization'; | ||
|
|
||
| import {useTraceEventView} from './useTraceEventView'; | ||
| import {type TraceViewQueryParams, useTraceQueryParams} from './useTraceQueryParams'; | ||
|
|
||
| function useTraceLevelOpsQuery( | ||
| traceSlug: string, | ||
| params: TraceViewQueryParams, | ||
| partialSavedQuery: Partial<NewQuery> | ||
| ) { | ||
| const location = useLocation(); | ||
| const organization = useOrganization(); | ||
| const eventView = useTraceEventView(traceSlug, params, { | ||
| ...partialSavedQuery, | ||
| dataset: DiscoverDatasets.SPANS_EAP, | ||
| }); | ||
|
|
||
| return useDiscoverQuery({ | ||
| eventView, | ||
| orgSlug: organization.slug, | ||
| location, | ||
| }); | ||
| } | ||
|
|
||
| function LoadingPlaceHolder() { | ||
| return ( | ||
| <Container> | ||
| <StyledPlaceholder height={'16px'} width={'100px'} /> | ||
| <StyledPlaceholder height={'16px'} width={'100px'} /> | ||
| <StyledPlaceholder height={'16px'} width={'100px'} /> | ||
| </Container> | ||
| ); | ||
| } | ||
|
|
||
| type Props = { | ||
| isTraceLoading: boolean; | ||
| traceSlug: string; | ||
| }; | ||
|
|
||
| export function TraceLevelOpsBreakdown({traceSlug, isTraceLoading}: Props) { | ||
| const urlParams = useTraceQueryParams(); | ||
| const { | ||
| data: opsCountsResult, | ||
| isPending: isOpsCountsLoading, | ||
| isError: isOpsCountsError, | ||
| } = useTraceLevelOpsQuery(traceSlug ?? '', urlParams, { | ||
| fields: ['span.op', 'count()'], | ||
| orderby: '-count', | ||
| }); | ||
| const { | ||
| data: totalCountResult, | ||
| isPending: isTotalCountLoading, | ||
| isError: isTotalCountError, | ||
| } = useTraceLevelOpsQuery(traceSlug ?? '', urlParams, { | ||
| fields: ['count()'], | ||
| }); | ||
|
|
||
| if (isOpsCountsLoading || isTotalCountLoading || isTraceLoading) { | ||
| return <LoadingPlaceHolder />; | ||
| } | ||
|
|
||
| if (isOpsCountsError || isTotalCountError) { | ||
| addErrorMessage(t('Failed to load trace level ops breakdown')); | ||
| return null; | ||
| } | ||
|
|
||
| const totalCount = totalCountResult?.data[0]?.['count()'] ?? 0; | ||
|
|
||
| if (typeof totalCount !== 'number' || totalCount <= 0) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <Container> | ||
| {opsCountsResult?.data.slice(0, 4).map(currOp => { | ||
| const operationName = currOp['span.op']; | ||
| const count = currOp['count()']; | ||
|
|
||
| if (typeof operationName !== 'string' || typeof count !== 'number') { | ||
| return null; | ||
| } | ||
|
|
||
| const percentage = count / totalCount; | ||
| const color = pickBarColor(operationName); | ||
| const pctLabel = isFinite(percentage) ? Math.round(percentage * 100) : '∞'; | ||
|
|
||
| return ( | ||
| <HighlightsOpRow key={operationName}> | ||
| <IconCircleFill size="xs" color={color as Color} /> | ||
| {operationName} | ||
| <span>{pctLabel}%</span> | ||
| </HighlightsOpRow> | ||
| ); | ||
| })} | ||
| </Container> | ||
| ); | ||
| } | ||
|
|
||
| const HighlightsOpRow = styled('div')` | ||
| display: flex; | ||
| align-items: center; | ||
| font-size: ${p => p.theme.fontSizeSmall}; | ||
| gap: 5px; | ||
| `; | ||
|
|
||
| const Container = styled('div')` | ||
| display: flex; | ||
| align-items: center; | ||
| padding-left: ${space(1)}; | ||
| gap: ${space(2)}; | ||
| `; | ||
|
|
||
| const StyledPlaceholder = styled(Placeholder)` | ||
| border-radius: ${p => p.theme.borderRadius}; | ||
| `; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters