Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN: Updates capture feedback documentation #11980

Merged
merged 11 commits into from
Feb 13, 2025

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Nov 27, 2024

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

This PR updates the the captureFeedback documentation and removes the deprecated captureUserFeedback.

Partially getsentry/sentry-react-native#4319

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 11:39am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 11:39am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 11:39am

@antonis antonis marked this pull request as draft November 27, 2024 16:34
Copy link

codecov bot commented Nov 27, 2024

Bundle Report

Changes will increase total bundle size by 69.42kB (0.34%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.0MB 69.43kB (0.64%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/uXON8ffNmmZxZ3vHgf738/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/uXON8ffNmmZxZ3vHgf738/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/1TwbHZ3GJaE-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/1TwbHZ3GJaE-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js 23.14kB 1.73MB 1.35%
../instrumentation.js 23.14kB 1.07MB 2.22%
9523.js 23.14kB 1.04MB 2.27%

@krystofwoldrich
Copy link
Member

@antonis I think this make sense to mark as ready for review and marge it with the release of https://github.com/getsentry/sentry-react-native/releases/tag/6.5.0-beta.1

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Dec 17, 2024

@antonis The UI Form changes can be a standalone docs change.

@krystofwoldrich krystofwoldrich marked this pull request as ready for review December 17, 2024 12:44
krystofwoldrich added a commit to getsentry/sentry-react-native that referenced this pull request Dec 17, 2024
@antonis
Copy link
Collaborator Author

antonis commented Dec 17, 2024

@antonis The UI Form changes can be a standalone docs change.

Makes sense @krystofwoldrich 👍

@krystofwoldrich
Copy link
Member

When getsentry/sentry-react-native#4386 is release and out of beta we can merge this.

@antonis
Copy link
Collaborator Author

antonis commented Jan 3, 2025

When getsentry/sentry-react-native#4386 is release and out of beta we can merge this.

@krystofwoldrich With the 6.5.0 out we can proceed with merging this

@antonis antonis requested a review from lucas-zimerman January 3, 2025 20:05
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@antonis antonis merged commit 842d2c5 into master Feb 13, 2025
11 checks passed
@antonis antonis deleted the antonis/react-native-capture-feedback branch February 13, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants