Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN: Add feedback widget documentation #12503

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Jan 29, 2025

⚠️ Based on: RN: Updates capture feedback documentation

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

Adds the Feedback Widget documentation for React Native

Part of getsentry/sentry-react-native#4302

Implementation PR: getsentry/sentry-react-native#4435

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Should be merged after getsentry/sentry-react-native#4435 is released

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 0:06am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 0:06am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 0:06am

Copy link

codecov bot commented Jan 31, 2025

Bundle Report

Changes will increase total bundle size by 70.02kB (0.34%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.01MB 70.03kB (0.64%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js 23.14kB 1.73MB 1.35%
../instrumentation.js 23.14kB 1.07MB 2.22%
9523.js 23.14kB 1.04MB 2.27%
../app/[[...path]]/page.js.nft.json 200 bytes 379.24kB 0.05%
../app/platform-redirect/page.js.nft.json 200 bytes 379.15kB 0.05%
../app/sitemap.xml/route.js.nft.json 200 bytes 377.12kB 0.05%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/6F1f9yMwF4JhRfEPxlMwU/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/6F1f9yMwF4JhRfEPxlMwU/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/B5kwTEaNOs0w0Im1t8MLS/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/B5kwTEaNOs0w0Im1t8MLS/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@antonis
Copy link
Collaborator Author

antonis commented Feb 18, 2025

Renamed form to widget with 639f64d to align with the changes in getsentry/sentry-react-native#4547

@antonis
Copy link
Collaborator Author

antonis commented Feb 18, 2025

Added screenshot thumbnail styles with 440b0c6

@antonis
Copy link
Collaborator Author

antonis commented Feb 18, 2025

Updated the onAddScreenshot callback with 48a7972


```javascript
import * as Sentry from "@sentry/react-native";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also hight light that the Root component has to be wrapped with Sentry.wrap for this to work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 👍
Added with 8a84abf


```javascript
import * as Sentry from "@sentry/react-native";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also hight light that the Root component has to be wrapped with Sentry.wrap for this to work.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with 8a84abf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants