New test games and a new test mixed script for these games #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulsavani
reviewed
Nov 22, 2023
| def negative_prob(self) -> bool: | ||
| """Returns True if at least one player has a negative \"probability\".""" | ||
| return self._negative_prob() | ||
|
|
||
| def _all_zero_probs(self) -> bool: |
There was a problem hiding this comment.
@tturocy I ended up with single implementations of _all_zero_probs and _negative_prob at the MixedStrategyProfile level. Do you see any reason for separate implementations in MixedStrategyProfileRational and MixedStrategyProfileDouble (maybe I missed something)?
VarsosC
commented
Nov 23, 2023
src/pygambit/tests/test_mixed.py
Outdated
| expect = round(compute_liap(), 10) | ||
| assert round(expect - mixed_strat.liap_value(), 10) == 0 | ||
|
|
||
| strat1 = [gbt.Rational(99, 100), gbt.Rational(27, 10000), gbt.Rational(27, 10000)] |
There was a problem hiding this comment.
Here the probabilities do not sum to one.
rahulsavani
force-pushed
the
TEST-374-write-better-tests-for-mixed-strategy-profiles
branch
from
f1f6a54 to
c4dbbe9
Compare
tturocy
force-pushed
the
TEST-374-write-better-tests-for-mixed-strategy-profiles
branch
5 times, most recently
from
cbbb7ec to
e6b16aa
Compare
tturocy
force-pushed
the
TEST-374-write-better-tests-for-mixed-strategy-profiles
branch
from
e6b16aa to
30b2ca9
Compare
tturocy
deleted the
TEST-374-write-better-tests-for-mixed-strategy-profiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.