Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: Write better tests for mixed strategy profiles #374

Closed
tturocy opened this issue Oct 6, 2023 · 0 comments · Fixed by #407
Closed

TEST: Write better tests for mixed strategy profiles #374

tturocy opened this issue Oct 6, 2023 · 0 comments · Fixed by #407
Assignees
@rahulsavani @VarsosC
Labels
good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python tests Items which involve the pygambit test suite
Milestone
gambit-16.2.0

Comments

@tturocy
Copy link
Member

tturocy commented Oct 6, 2023

There is currently a simple set of tests on mixed strategy profiles (see src/pygambit/tests/test_mixed.py). At the moment these tests do exercise the code to ensure the function calls are defined, but the tests are done on a trivial strategic game with payoffs all equal to zero, so the payoff, strategy value, and liap value calculations are not very interesting.

Design a set of fixtures/parameterisations for these tests which exercise the calculations on more interesting games and mixed strategy profiles.
@tturocy tturocy added good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python tests Items which involve the pygambit test suite labels Oct 6, 2023
@tturocy tturocy added this to the gambit-16.2.0 milestone Oct 6, 2023
@tturocy tturocy mentioned this issue Oct 6, 2023
Closed
@VarsosC VarsosC self-assigned this Oct 14, 2023
@tturocy tturocy mentioned this issue Oct 19, 2023
Closed
@rahulsavani rahulsavani self-assigned this Nov 6, 2023
@VarsosC VarsosC linked a pull request Nov 14, 2023 that will close this issue
New test games and a new test mixed script for these games #407
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulsavani rahulsavani

@VarsosC VarsosC

Labels
good-first-issue Items which are (relatively) straightforward, and good ways to get into the code python Items which involve coding in Python tests Items which involve the pygambit test suite
Projects
None yet
Milestone
gambit-16.2.0
Development

Successfully merging a pull request may close this issue.

New test games and a new test mixed script for these games gambitproject/gambit
3 participants
@tturocy @rahulsavani @VarsosC