Enable apply_delens=True in CMBLensed #214
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. please post the notebook to gist.github.com and link it in the pull request. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,197 @@ | ||
| { | ||
| "cells": [ | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "# For clarity, this addresses Issue 213 only" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 1, | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "import pysm3\n", | ||
| "import pysm3.units as u\n", | ||
| "from pysm3.models.cmb import CMBMap\n", | ||
| "from pysm3.models.cmb import CMBLensed as CMBLensedOriginal" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "# Issue 213" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "When running CMBLensed with `apply_delens=True`, there is a ValueError." | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 2, | ||
| "metadata": {}, | ||
| "outputs": [ | ||
| { | ||
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "operands could not be broadcast together with shapes (2199,) (2,) \n" | ||
| ] | ||
| } | ||
| ], | ||
| "source": [ | ||
| "try:\n", | ||
| " will_crash = CMBLensedOriginal(\n", | ||
| " nside=128,\n", | ||
| " cmb_spectra='pysm_2/camb_lenspotentialCls.dat',\n", | ||
| " # max_nside=None,\n", | ||
| " # cmb_seed=0,\n", | ||
| " apply_delens=True,\n", | ||
| " delensing_ells='pysm_2/delens_ells.txt',\n", | ||
| " # map_dist=None,\n", | ||
| " )\n", | ||
| "except ValueError as e:\n", | ||
| " print(e)" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "# Resolution" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "At line (43), adding `unpack=True`, resolves this:" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 3, | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "# Revised, minimal changes to the __init__ method are all that is needed\n", | ||
| "\n", | ||
| "class CMBLensedRevised(CMBMap):\n", | ||
| " # intherit from CMBMap so we get the `get_emission` method\n", | ||
| " def __init__(\n", | ||
| " self,\n", | ||
| " nside,\n", | ||
| " cmb_spectra,\n", | ||
| " max_nside=None,\n", | ||
| " cmb_seed=None,\n", | ||
| " apply_delens=False,\n", | ||
| " delensing_ells=None,\n", | ||
| " map_dist=None,\n", | ||
| " ):\n", | ||
| " \"\"\"Lensed CMB\n", | ||
| "\n", | ||
| " Takes an input unlensed CMB and lensing spectrum from CAMB and uses\n", | ||
| " Taylens to apply lensing, it optionally simulates delensing by\n", | ||
| " suppressing the lensing power at specific scales with the user\n", | ||
| " provided `delensing_ells`.\n", | ||
| "\n", | ||
| " Parameters\n", | ||
| " ----------\n", | ||
| "\n", | ||
| " cmb_spectra : path\n", | ||
| " Input text file from CAMB, spectra unlensed\n", | ||
| " cmb_seed : int\n", | ||
| " Numpy random seed for synfast, set to None for a random seed\n", | ||
| " apply_delens : bool\n", | ||
| " If true, simulate delensing with taylens\n", | ||
| " delensing_ells : path\n", | ||
| " Space delimited file with ells in the first columns and suppression\n", | ||
| " factor (1 for no suppression) in the second column\n", | ||
| " \"\"\"\n", | ||
| " try:\n", | ||
| " super().__init__(nside=nside, max_nside=max_nside, map_dist=map_dist)\n", | ||
| " except ValueError:\n", | ||
| " pass # suppress exception about not providing any input map\n", | ||
| " self.cmb_spectra = self.read_txt(cmb_spectra, unpack=True)\n", | ||
| " self.cmb_seed = cmb_seed\n", | ||
| " self.apply_delens = apply_delens\n", | ||
| " self.delensing_ells = (\n", | ||
| " None if delensing_ells is None else self.read_txt(delensing_ells, \n", | ||
| " unpack=True)\n", | ||
| " )\n", | ||
| "\n", | ||
| " self.map = u.Quantity(self.run_taylens(), unit=u.uK_CMB, copy=False)\n", | ||
| "\n", | ||
| "\n", | ||
| " def run_taylens(self):\n", | ||
| " pass\n", | ||
| "\n", | ||
| "CMBLensedRevised.run_taylens = CMBLensedOriginal.run_taylens" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 4, | ||
| "metadata": {}, | ||
| "outputs": [ | ||
| { | ||
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "Successful run.\n" | ||
| ] | ||
| } | ||
| ], | ||
| "source": [ | ||
| "try:\n", | ||
| " will_run = CMBLensedRevised(\n", | ||
| " nside=128,\n", | ||
| " cmb_spectra='pysm_2/camb_lenspotentialCls.dat',\n", | ||
| " # max_nside=None,\n", | ||
| " # cmb_seed=0,\n", | ||
| " apply_delens=True,\n", | ||
| " delensing_ells='pysm_2/delens_ells.txt',\n", | ||
| " # map_dist=None,\n", | ||
| " )\n", | ||
| " print(\"Successful run.\")\n", | ||
| "except ValueError as e:\n", | ||
| " print(e)" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Because the `c1` delensing ells are a no-op (it is a column of 1's), no change is seen when applying delensing_ells. I do not know enough about the method to evaluate success or failure. When addressing Issue 212, it needs to account for this as well." | ||
| ] | ||
| } | ||
| ], | ||
| "metadata": { | ||
| "kernelspec": { | ||
| "display_name": "cmb-ml2", | ||
| "language": "python", | ||
| "name": "python3" | ||
| }, | ||
| "language_info": { | ||
| "codemirror_mode": { | ||
| "name": "ipython", | ||
| "version": 3 | ||
| }, | ||
| "file_extension": ".py", | ||
| "mimetype": "text/x-python", | ||
| "name": "python", | ||
| "nbconvert_exporter": "python", | ||
| "pygments_lexer": "ipython3", | ||
| "version": "3.9.21" | ||
| } | ||
| }, | ||
| "nbformat": 4, | ||
| "nbformat_minor": 2 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specify it is a shape error,
add link to this pull request