Enable apply_delens=True in CMBLensed #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
There's a flaw in the notebook that I failed to notice (spectra are not included in the PR). I'll find another approach. |
|
There was a fast fix without needing external files. |
zonca
requested changes
Mar 4, 2025
| @@ -7,6 +7,7 @@ | |||
| - Updated `pixell` from 0.17.3 to 0.26.0 https://github.com/galsci/pysm/pull/183 | |||
| - Initial implementation of a point source catalog component emission https://github.com/galsci/pysm/pull/187 | |||
| - Switch the build system to Hatch https://github.com/galsci/pysm/pull/189 | |||
| - Fix bug in `CMBLensed` preventing use of `apply_delens=True` | |||
There was a problem hiding this comment.
specify it is a shape error,
add link to this pull request
There was a problem hiding this comment.
please post the notebook to gist.github.com and link it in the pull request.
Remove it from the pull request.
| delensing_ells='pysm_2/delens_ells.txt' | ||
| ) | ||
| except ValueError: | ||
| pytest.fail(f"ValueError raised when applying delensing") |
There was a problem hiding this comment.
do not use a try except block.
split the test in 2 tests:
test_cmb_lensed_no_delens
test_cmb_lensed_delens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:
apply_delens=TrueinCMBLensedpreviously caused a ValueError ( #213 ).I included a notebook at the top level to avoid import issues. Let me know if you'd like me to move it elsewhere.