Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add return type hint to Metric.read() #110

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

msto
Copy link
Contributor

@msto msto commented May 6, 2024

this can be typed more specifically than Any

@msto msto requested review from nh13, tfenne, clintval and TedBrookings May 6, 2024 13:46
Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@msto msto merged commit f23a4ea into main May 23, 2024
6 checks passed
@msto msto deleted the ms_add-type-hint-to-read branch May 23, 2024 18:28
msto added a commit that referenced this pull request Aug 2, 2024
nh13 pushed a commit that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants