Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Add return type hint to Metric.read()" #173

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

msto
Copy link
Contributor

@msto msto commented Aug 2, 2024

Reverts #110

Closes #172

@msto msto requested review from nh13 and tfenne as code owners August 2, 2024 15:08
@msto msto assigned nh13 Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.14%. Comparing base (02d6633) to head (aa7ff4e).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   89.14%   89.14%           
=======================================
  Files          17       17           
  Lines        2026     2026           
  Branches      446      446           
=======================================
  Hits         1806     1806           
  Misses        144      144           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13 nh13 merged commit 4717291 into main Aug 2, 2024
8 checks passed
@nh13 nh13 deleted the revert-110-ms_add-type-hint-to-read branch August 2, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Incompatible types in assignment with Metric.read
2 participants