Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config for the SensesField #4976

Open
wants to merge 13 commits into
base: 4.2.x
Choose a base branch
from

Conversation

Larkinabout
Copy link
Contributor

Intended to allow custom senses by editing CONFIG.DND5E.senses.

image

@Larkinabout Larkinabout marked this pull request as draft January 9, 2025 12:31
@arbron arbron linked an issue Jan 9, 2025 that may be closed by this pull request
@arbron arbron added this to the D&D5E 4.3.0 milestone Jan 9, 2025
Larkinabout and others added 2 commits January 13, 2025 16:58
- Add the types object to the movement object.
- Add migration to migrate movements and senses to the types object.
@Larkinabout
Copy link
Contributor Author

I believe the only thing left to do is resolve MovementSensesConfig._preparePartContext, though I'm still not clear on how to do it. I'll keep trying to figure it out, but would be grateful for anyone's insight to speed me along.

@Larkinabout
Copy link
Contributor Author

Larkinabout commented Jan 16, 2025

Note to remind that we may wish to also move group actor movement types into a types object for consistency, but for the moment I've handled it in movement-senses-config.mjs.

Also, would be useful to allow group movement to also be configurable. CONFIG.DND5E.vehicleTypes could be viable, but it includes space, which would need to be excluded by default in the various places where movement is determined. This would cause an issue if a user actually wants to add space as a movement type.

@arbron
Copy link
Collaborator

arbron commented Jan 16, 2025

@Larkinabout It would be good to take the compendium changes out of this PR, we can handle them later and we'll want to make sure that the migrations in place are enough to keep compendium content working even if it doesn't have the new data layout (plus it makes it easier to review)

@Larkinabout
Copy link
Contributor Author

@Larkinabout It would be good to take the compendium changes out of this PR, we can handle them later and we'll want to make sure that the migrations in place are enough to keep compendium content working even if it doesn't have the new data layout (plus it makes it easier to review)

Understandable, will sort soon.

@krbz999
Copy link
Contributor

krbz999 commented Jan 17, 2025

This probably also needs migrations for ActiveEffects. All AEs that modify system.attributes.senses.* should point at something different, or we just support the same deprecated property but point it elsewhere in the AE document class.

@Larkinabout Larkinabout marked this pull request as ready for review January 19, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SensesField should pull the properties from CONFIG.DND5E.senses
3 participants