FIO-9499 Component: Check if ref is instance of NodeList on detach #5972
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
closely related, but not directly responsible for the initial bug. It was discovered while working on:
https://formio.atlassian.net/browse/FIO-9499
Description
What changed?
Updated check from
typeof ref === NodeList
toref instanceof NodeList
since the former returns'object'
and not what we're checking for'NodeList'
.Why have you chosen this solution?
So that the result of this conditional is what we're expecting.
Breaking Changes / Backwards Compatibility
n/a
Dependencies
n/a
How has this PR been tested?
Manual testing + automated test in
formio
repo formio/formio#1885.Checklist: