Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-9499 Component: Check for existence of window.NodeList on detach #5972

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

FIO-9499 Component: Check for existence of window.NodeList on detach #5972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/_classes/component/Component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1480,7 +1480,7 @@
detach() {
// First iterate through each ref and delete the component so there are no dangling component references.
_.each(this.refs, (ref) => {
if (typeof ref === NodeList) {
if (window?.NodeList && ref instanceof NodeList) {
ref.forEach((elem) => {
delete elem.component;
});
Expand Down Expand Up @@ -3039,7 +3039,7 @@

/**
* Returns if the value (e.g. array) should be divided between several inputs
* @returns {boolean}

Check warning on line 3042 in src/components/_classes/component/Component.js

View workflow job for this annotation

GitHub Actions / setup 

Missing JSDoc @returns description
*/
isSingleInputValue() {
return false;
Expand Down
Loading