-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.x - FIO-8426: changes required for eSignature #5633
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3b83d8c
5.x - FIO-8426: changes required for eSignature
TanyaGashtold 8d2b30d
added types and description
TanyaGashtold 53931b9
refactored types
TanyaGashtold 3e0990b
added description for renderModalPreview returned value
TanyaGashtold fde3bc9
Merge branch 'master' into FIO-8426-eSignature-changes-for-5x
TanyaGashtold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1176,6 +1176,15 @@ export default class Component extends Element { | |
this.componentModal.setOpenModalElement(template || this.getModalPreviewTemplate()); | ||
} | ||
|
||
/** | ||
* Renders a modal preview template and returns the markup as a string | ||
* @param {object|null|undefined} ctx - The rendering context | ||
* @return {string} - The modal preview markup | ||
*/ | ||
renderModalPreview(ctx) { | ||
return this.renderTemplate('modalPreview', ctx || {}); | ||
} | ||
|
||
getModalPreviewTemplate() { | ||
const dataValue = this.component.type === 'password' ? this.dataValue.replace(/./g, '•') : this.dataValue; | ||
let modalLabel; | ||
|
@@ -1184,7 +1193,7 @@ export default class Component extends Element { | |
modalLabel = { className: 'field-required' }; | ||
} | ||
|
||
return this.renderTemplate('modalPreview', { | ||
return this.renderModalPreview({ | ||
previewText: this.getValueAsString(dataValue, { modalPreview: true }) || this.t('Click to set value'), | ||
messages: '', | ||
labelInfo: modalLabel, | ||
|
@@ -1227,22 +1236,33 @@ export default class Component extends Element { | |
} | ||
} | ||
|
||
/** | ||
* Creates the tooltip instance using tippy.js and returns it | ||
* @param {HTMLElement} tooltipEl - HTML element to attach the tooltip | ||
* @param {object|null|undefined} settings - tippy.js options | ||
* @return {import('tippy.js').Tippy} - tippy.js instance | ||
*/ | ||
createTooltip(tooltipEl, settings = {}) { | ||
const tooltipAttribute = tooltipEl.getAttribute('data-tooltip'); | ||
const tooltipDataTitle = tooltipEl.getAttribute('data-title'); | ||
const tooltipText = this.interpolate(tooltipDataTitle || tooltipAttribute) | ||
.replace(/(?:\r\n|\r|\n)/g, '<br />'); | ||
|
||
return tippy(tooltipEl, { | ||
allowHTML: true, | ||
trigger: 'mouseenter click focus', | ||
placement: 'right', | ||
zIndex: 10000, | ||
interactive: true, | ||
...settings, | ||
content: this.t(this.sanitize(tooltipText), { _userInput: true }), | ||
}); | ||
} | ||
|
||
attachTooltips(toolTipsRefs) { | ||
toolTipsRefs?.forEach((tooltip, index) => { | ||
if (tooltip) { | ||
const tooltipAttribute = tooltip.getAttribute('data-tooltip'); | ||
const tooltipDataTitle = tooltip.getAttribute('data-title'); | ||
const tooltipText = this.interpolate(tooltipDataTitle || tooltipAttribute) | ||
.replace(/(?:\r\n|\r|\n)/g, '<br />'); | ||
|
||
this.tooltips[index] = tippy(tooltip, { | ||
allowHTML: true, | ||
trigger: 'mouseenter click focus', | ||
placement: 'right', | ||
zIndex: 10000, | ||
interactive: true, | ||
content: this.t(this.sanitize(tooltipText), { _userInput: true }), | ||
}); | ||
this.tooltips[index] = this.createTooltip(tooltip); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. very nice |
||
} | ||
}); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a HUGE nit, but the incoming PR from Travis will cause the linter to complain about this - can we get into the habit of adding descriptions and types for each (even any will do, although I have a JSON type in Form.js)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!